Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation #999

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

DimitriDR
Copy link

Hey,

Here's the French version of the app. Just a draft, I have few things to check first.

Also, be careful, I had to change the team of the app to be able to run it on my Mac. I couldn't ignore this file from Git because it contains other important information.

DimitriDR and others added 3 commits June 15, 2024 16:45
Signed-off-by: DimitriDR <dimitridroeck@gmail.com>
Signed-off-by: DimitriDR <dimitridroeck@gmail.com>
@DimitriDR
Copy link
Author

Before being ready, last question: do I need to translate strings with "< blabla >"?

noah-nuebling added a commit that referenced this pull request Aug 30, 2024
…wesomeee. I also change a few small things in the French Localizable.strings. For example I made the trigger.[...] strings lowercase, fixed the trigger.scroll-particle, and trigger.drag-particle, and carried over as much as possible of the translations to the new capture-toast.[...] string keys. Also modified the Brazilian portugese trigger.[...] strings in the same way. (Several translators are getting the same thing wrong so I need to make this easier/clearer somehow)
noah-nuebling added a commit that referenced this pull request Sep 16, 2024
…e URLMenuItem to using Links.m, added kMFLinkIDGuidesAndCommunity. Added validation to Hyperlink.m and URLMenuItem.m, Removed IBInspectable from the old Hyperlink.href and URLMenuItem.URLString. Maybe more I forgot.

----

Our TODO in Notes now looks like this:

Notes from going through all the German strings in the .xcloc file

- [x] (?) Remove window title saying "Mac Mouse Fix", cause it's kinda implied by context (?)
    * Not doing this kinda big thing now
- [x] (?) Flag pointertab stuff as "don't translate"
- [x] Mark bundle name in Info.plist as 'do not translate'
    - [x] Also the copyright (?)
    - [x] Also for the Helper bundle
- [x] Remove Chocolate, Vanilla, Strawberry strings
- [x] Improve the "is not a known license key" text in English and German

Code:
- [x] Make it impossible to enter linebreaks in the license field.
- [x] Make automated screenshots of restore buttons popover (I feel like it's confusing to translate with just text.)
- [x] Remove screenshots for collapsed views
	Really bad/confusing example is:
        * N65-aN-Hxp.title - "Trackpad Simulation",
        * effect.apple-keys-submenu
    - [x] Remove screenshots for non-visible alternate menu items (such as the "Apple Exclusive Keys" menu item.)
- [x] Make Markdown.xcstrings be exported
    - [x] Then go through all the markdown strings
    - [x] Then go through all the website strings.

Mark for review:
    - [x] Mark the new capture notification strings for review
    - [x] Mark anything else missing I can find in Chinese translation for review (all the stuff I added recently and which hasn't been translated is marked as translated for some reason.)
    - [x] Mark any issues from the State of Localization for review.
        * Done. See Latest State of Localization from 19.05.2024
Finally:
- [x] Add all the locales the default locales that crowdin uses to the project.
- [ ] Import all the localizations people have sent
    * Brazilian Portugese translator: message:<C5C42788-081E-4FE1-960A-0FDF512D77FD@icloud.com>
        * Other pt-BR translator who offered: #731 (comment)
        - [x] Import
        - [ ] Review (built app)
        - [ ] Add credits
        - [ ] Send review-request
    * French PR: #999
        - [x] Import
        - [ ] Review (built app)
        - [ ] Add credits
        - [ ] Send review-request.
    * Turkish PR: #919
        - [x] Import
        - [ ] Review (built app)
        - [ ] Add credits
        - [ ] Send review-request.
    * Polish guy who offered to translate (but hasn't translated, yet): message:<ac30aeea-1bbe-4eb3-80ac-dd02b7c03f3b@Spark>

Translation Backend:
- [x] Both french and brazilian translator made mistake on `trigger.scroll-particle`. Improve.
    - [x] Also rename the related button-modifier.[...] strings with trigger.substring.[...] prefix.
    - [x] People also made capitalization mistakes (?) on button-string.[...] strings. Improve comments! (Maybe say 'this string will not always appear at the start of the line and shouldn't be capitalized in most languages. Capitalize for title case (English)  or Noun case (in German and other langs).')
        * New idea -> Refactor button-string.[...] strings. (Create copy of them with trigger.substring prefix. Maybe remove button-string.tool.[...] because it doesn't make grammatical sense in German.)
- [x] Remove all the 'First draft:' strings.
- [x] Go through recent changes and also apply them to pt-BR (we forgot since the localization progress on that was set to 0%)
* ---
* Comments:
    - [x] Add explanation comments to system-settings-name and system-settings-name.pre-ventura
    - [x] Update comments on @uncaptured/@captured placeholders (Brazilian translator translated them but didn't translate the replacement, which would break the translation.)
    - [x] Update `First draft: **Buttons** || Note: Will be inserted into the revive-toast` to say 'into the 'revive-toast' string.
* Links:
    - [x] Move [link](s) out of .xcstrings file and into code (So we can localized them properly) E.g. capture-toast.buttons.link
    - [ ] Move links out of IB files (Hyperlink.m instances) and into code. (So we can localize them.)
        - [x] Hyperlink instances
        - [x] URLMenuItem instances
- [ ] Put mouse name in parens in restore-buttons-alert (inspired by what the Korean translator did the popover string)
- [ ] Number all c-format-specifiers if several specifiers appear in same string. E.g. license-toast.activation-overload
- [ ] Add all the new languages to the `informationDensityOfLanguage` map.

Other:
- [ ] Change usage of .../redirection-service/ to redirect.macmousefix.com/ throughout project.
- [ ] Prevent 'if you have problem enabling' popup from showing up after app has already enabled (that happens sometimes for some reason.)
- [ ] Adjust the strange helper alert, and 'if you have problems enabling' popup for macOS Sequoia.
- [ ] Update `fallback_licenseinfo_config.json`
Website:
- [x] Test on mobile
- [x] Fix jank when expanding quote cards and then scrolling up into the zoom animation
- [x] Fix jank when expanding / unexpanding feature cards repeatedly. (Can't reproduce this anymore)
- [ ] Bring enhancements from localizationProgress of website to the .md files. (Make the localizationProgress message itself localizable.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant