Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working snap created #117

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Working snap created #117

merged 7 commits into from
Sep 12, 2024

Conversation

kz6fittycent
Copy link
Contributor

Hi,

I've recently created a snap for jqp and have it working with strict confinement. Meaning it will run "as native" within a snap container for any Linux distro supporting snapd. Learn more about snaps here.

I am happy to maintain the snap for your project, unless you'd prefer maintaining it all "in-house". There's not much anyone on the team would have to do, as the snaps are automatically built and published on the snap store.

As part of the security checks, pedigree, and validation, the upstream team/devs should at least know about it and agree with the publication of the snap. Basically, the snap will much like a .deb or .rpm on another distro supporting those packages; except it's distro agnostic.

I hope this comes as a welcome PR.

New files:

  • Snapcraft yaml
  • GH Workflow - test-snap-can-build
  • Updated README with snap instructions

- Snapcraft yaml
- GH Workflow - test-snap-can-build
- Updated README with snap instructions
Copy link
Owner

@noahgorstein noahgorstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kz6fittycent - thanks for your contribution!

I'm happy to let you maintain the snap for jqp.

if you don't mind just cleaning up the typo in the readme, I'll merge it after that.

@kz6fittycent
Copy link
Contributor Author

Thanks @noahgorstein I need to add that workflow to my own repos! I can't tell you how many times I've missed typos.

Added more info
@kz6fittycent
Copy link
Contributor Author

kz6fittycent commented Sep 6, 2024

The snap has been published! Thanks for working w/ me on this.

@noahgorstein noahgorstein merged commit a75e3e7 into noahgorstein:main Sep 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants