config: option for overrides to chroma styles #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktprograms
force-pushed
the
chroma-style-overrides
branch
from
ad6fa7b
to
10b5f6e
Compare
|
Thanks for your PR @ktprograms. I'll be out of town without my computer for about a week but will try to get to this when I'm back later next week. Cheers. |
noahgorstein
requested changes
Oct 28, 2022
There was a problem hiding this comment.
This looks and works great @ktprograms. Small typo in the README but good to go otherwise. Thanks again for your contribution and apologies for just getting around to review this.
User facing changes: - Remove file option from config - Move theme option to theme.name - Add theme.chromaStyleOverrides map for style overrides Code changes: - Copy code from quick.Highlight to use chroma.Style object instead of looking up by name - Pass chroma.Style pointer instead of object as chroma Format requires style pointer Fix: noahgorstein#27 Fix: noahgorstein#30
ktprograms
force-pushed
the
chroma-style-overrides
branch
from
10b5f6e
to
b6f3043
Compare
noahgorstein
approved these changes
Jan 7, 2023
noahgorstein
added a commit
that referenced
this pull request
Jan 7, 2023
This reverts commit b73ad78.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changes:
Code changes:
Fix: #27
Fix: #30