feat(react-centra-checkout): add support for passing token details to useCentraOrders #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vercel
bot
temporarily deployed
to
Preview – react-centra-checkout-docs
vercel
bot
temporarily deployed
to
Preview – react-centra-checkout-docs
vercel
bot
temporarily deployed
to
Preview – react-centra-checkout-docs
vercel
bot
temporarily deployed
to
Preview – react-centra-checkout-docs
Thomas0c
changed the title
Comment on lines
+646
to
+650
| token?: { | ||
| tokenName?: string | ||
| tokenExpires?: number | Date | ||
| tokenCookieOptions?: Cookies.CookieAttributes | ||
| }, |
There was a problem hiding this comment.
question: Is this necessary?
suggestion: Would be nice if we can enforce that tokenName in both the Context as well as inside useCentraOrders.
maeertin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiencing that initial call to
useCentraOrdersreturns 403 (access denied) given that the api-token header is not set unless one or more other calls have been made prior. Thus allowing for passing a token name and reading this, when callinguseCentraOrdersto avoid this.Similarly also checking if returned token does not correspond with the initial - and if so updating the token cookie.