fix: check that last_non_whitespace_character is not an empty string #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamgat
added a commit
that referenced
this pull request
May 17, 2024
|
Thank you for finding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem where JSON Schema could end up with leading commas. The problem was that
last_non_whitespace_characteris set to an empty string if there has not been a non whitespace character, but the check that increments num_items didn't handle that case.Dealign with the empty string is a bit unsatisfying, but I didn't feel comfortable with all of the implications of refactoring it other than to add the check.
Resolves #99