fix(acp): preserve file attachment metadata during session replay #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Github Action <action@github.com>
Co-authored-by: Adam <2363879+adamdotdevin@users.noreply.github.com>
…alyco#6199) Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
…pm install method
This reverts commit 26e7043.
This reverts commit 505068d.
Co-authored-by: OpenCode <opencode@example.com>
…o#6332) Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…yco#6306) Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
…malyco#6304) Co-authored-by: OpenCode <opencode@example.com> Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
- Store ACP resources as file parts to preserve filename and mimeType - Add file part handling in processMessage for proper session replay - Decode text-based files for LLM compatibility in toModelMessage - Preserve original filename from image URI instead of hardcoding 'image' - Skip binary non-image files during ACP replay (resource blocks only support text) - Follow style guide: avoid else statements, use Buffer instead of atob/btoa
- Filter synthetic text parts during ACP replay to avoid showing internal messages - Convert ACP resources to data URLs preserving original filename from URI - Use whitelist approach for binary content (image/audio/video/pdf) instead of blacklisting text MIME types - Handle edge cases where resource has empty text/blob fields
…ta during session replay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the file attachment fixes from liorshk/opencode.
Changes
See PR anomalyco#6342 on sst/opencode for full details.