Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Mismatch on "banner_header" key #121

Closed
Aeases opened this issue Sep 17, 2023 · 3 comments
Closed

Type Mismatch on "banner_header" key #121

Aeases opened this issue Sep 17, 2023 · 3 comments

Comments

@Aeases
Copy link

Aeases commented Sep 17, 2023

The automatic header filename uses a boolean, where as the custom name uses a string, could cause incompatibilities with the upcoming obsidian databases & gives you a ugly (kinda nice looking) warning symbol depending on whether your first banner header was a filename or a custom one.

image

One solution could be to just use a word like "filename" to trigger the automatic header, could allow the user to change that in setting too

@noatpad
Copy link
Owner

noatpad commented Sep 17, 2023

That's true actually. I forgot about the upcoming database changes would probably require properties to be consistent with their types. For the time being, I think using an empty string could also work to trigger the automatic filename

@Aeases
Copy link
Author

Aeases commented Sep 18, 2023

Yea that sounds like a better solution, great this will be fixed b4 it's out of beta!

@noatpad
Copy link
Owner

noatpad commented Sep 20, 2023

All good to go in https://github.com/noatpad/obsidian-banners/releases/tag/2.0.2-beta! An empty (or rather null) value will now trigger the auto filename insertion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants