Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fetch() with requestUrl() to resolve #118 #119

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Replace fetch() with requestUrl() to resolve #118 #119

merged 1 commit into from
Sep 17, 2023

Conversation

RyotaUshio
Copy link

@RyotaUshio RyotaUshio commented Sep 17, 2023 •
edited
Loading

Context: #118

It now works:

image

@RyotaUshio RyotaUshio changed the base branch from master to v2 September 17, 2023 07:24
@noatpad
Copy link
Owner

noatpad commented Sep 17, 2023

Ah, so that's how you use it! I was struggling to figure out how to get a blob out of requestUrl(), but this works perfectly.

Gonna merge this into master since that's where I'm applying the most recent v2 changes. Thank you!

@noatpad noatpad changed the base branch from v2 to master September 17, 2023 16:11
@noatpad noatpad merged commit d35240c into noatpad:master Sep 17, 2023
@RyotaUshio
Copy link
Author

I'm happy I could contribute to this lovely project! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyotaUshio @noatpad