This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
feat(capture): check if camera is available before trying to capture #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Thithip thanks for the MR |
|
Ok, I'll do this later. Thanks for review 👍 |
Thithip
force-pushed
the
fix/check_is_camera_are_available
branch
2 times, most recently
from
040eb49 to
22a6f9f
Compare
|
@luifr10 I split this MR into 4 commits, to add clarity on it. Tell me if it's ok for you. I can split into multiple MR if you think it makes more sense. |
luifr10
suggested changes
Mar 30, 2024
lib/page/capture_page.dart
Outdated
| return Scaffold( | ||
| appBar: AppBar(), | ||
| body: const Center( | ||
| child: Text('No camera found for this device'), |
There was a problem hiding this comment.
Please use the i10n mechanism:
- First add a new key (newAddedKey) to the
lib/l10n/app_en.arbandlib/l10n/app_fr.arbfiles. - Then use it in dart file :
AppLocalizations.of(context)!.newAddedKey
There was a problem hiding this comment.
Oh yes, nice catch!
I forgot this, sorry.
On some devices (desktop, web, iOS emulators) camera can be unavailable, and the app display a verbose error. With this feature, we display an error for the User, and the way to return the Home page (thanks to the Scaffold).
- remove hard-coded SizedBox - add a more dynamic way to scroll over Sequences, no matter the device size - no more cover the "Your sequences" title list
On local, Android behavior differ from others platforms with a specific `10.0.2.2` address. Adding a condition on this allows others devices (such as iOS, MacOS, or desktop) to connect to the local API for tests
- apply lint - add const when needed - fix misspelling issue - remove unnecessary `new` keyword
Thithip
force-pushed
the
fix/check_is_camera_are_available
branch
from
22a6f9f to
f17b41a
Compare
luifr10
approved these changes
Apr 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some devices (desktop, web, iOS emulators) camera can be unavailable, and the app display a verbose error.
With this feature, we display an error for the User, and the way to return the Home page (thanks to the Scaffold).
Plus, I fix the scroll on Home page (by removing the hard-coded
SizedBox), to allow scrolling on every devices, no matter the size of it.And I apply some lint issues (
const, brackets, misspelling word).I can split this MR is multiple if you consider this one is too big, or if you think some changes are not mandatory.
Please let me know if you want I add/remove some stuff here ;)