-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Pixel 6 - Android 14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes ok for me, can you please correct the E2E tests performed during the CI ?
I have added a tooltip to the photo capture button. However, it is not an actual button but a GestureDetector. Consequently, the test 'iShouldSeeAButtonNamed($, 'Take a picture');' does not work. I don't want to delete this test, but I'm unsure how to modify it to make it pass. |
@luifr10 I I am unable to fix the integration test. |
@OtterWays don't worry, I'll take a look |
I just realized that the behavior of the capture page has changed aha.
|
379bdf7
to
a0a934d
Compare
a0a934d
to
aa1ffc9
Compare
Hello @OtterWays ! integration_tests are now OK, here are the changes I've made :
I also made a rebase on the main branch, it's better to do a rebase instead of a merge to update with the main branch. If it's ok for you, we can merge then |
I modified the UI according to the mockups provided.
It is now impossible to take photos in portrait mode and the buttons have been redone for landscape mode.
The burst mode is not yet implemented and will be in #33