Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org-remark: error during loading highlights: (args-out-of-range...) #89

Closed
nobiot opened this issue Nov 2, 2024 · 5 comments
Closed

Comments

@nobiot
Copy link
Owner

nobiot commented Nov 2, 2024

Org-remark: error during loading highlights: (args-out-of-range # 2920 2965)

Repro:

  1. Find-file to visit a file with remarks. You get the highlights loaded successfully.
  2. Deactivate org-remark-mode
  3. Narrow the buffer to a heading (eg in markdown-mode)
  4. Reactivate org-remark-mode
@nobiot
Copy link
Owner Author

nobiot commented Nov 2, 2024

See e07dbdd

@nobiot nobiot closed this as completed Nov 2, 2024
@nobiot
Copy link
Owner Author

nobiot commented Nov 3, 2024

@akashpal-21, I think this is the error you reported originally with #83. I hope it is fixed now.

@akashpal-21
Copy link

Fix confirmed.

I was patching the save function, but I did not consider there -- that I was not considering the problem of highlights loading when initialising org-remark-mode from the narrowed position,

Thanks for pushing the fix. Much appreciated.

@nobiot
Copy link
Owner Author

nobiot commented Nov 3, 2024

Thabk you for your time to confirm this :)

@nobiot
Copy link
Owner Author

nobiot commented Nov 3, 2024

Wait... Maybe I will also need to look at the save process too then. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants