SRE-861 add readme and additional variables #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you have a failing linting error |
kgreczka9
approved these changes
Jul 25, 2022
| ## Some data sources require additional authentification | ||
| dataSourceAuthName: | ||
|
|
||
| ## Some data sources require additional secrets for authentification |
There was a problem hiding this comment.
Would be great to see some example usage. Like here:
https://github.com/grafana/helm-charts/blob/main/charts/grafana/values.yaml#L34
There was a problem hiding this comment.
Yep thats next PR with changes to deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.