Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge abandonware changes #926

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Merge abandonware changes #926

wants to merge 17 commits into from

Conversation

rzr
Copy link

@rzr rzr commented Feb 20, 2020

Hi,

Here is a first batch of changes from @abandonware fork

Feedback welcome from @sandeepmistry @opencollective or anyone else

About @abandonware org:

https://abandonware.github.io/

Relate-to: abandonware#2
Relate-to: #923

rzr added 4 commits December 19, 2018 15:15
@rzr
npm: Pin versions for node-8
aa8b8c9 
Node-10 to be then supported

Origin: noble@e2c476e
Forwarded: noble#851
Change-Id: I3c20732e71456cbe2b33509ccf2e0b72ca75442f
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@rzr
travis: Prevent SSL issue on node 0.8
7cb7409 
Change-Id: I84415cf2fe5f450fd6aab3429ea14c4cb816cb91
Origin: #1
Forwarded: noble#851
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@rzr
travis: Drop support of node-0.8
6875338 
Might be obsolete and it does not worth to keep maintaining it
Relate-To: https://travis-ci.org/abandonware/noble/jobs/470026600

Change-Id: I04be1fa73626402bb81775b056cabde32ced0960
Origin: #1
Forwarded: noble#851
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@rzr
npm: Set 0.10 as minimal engine
9137bd9 
Change-Id: I661e9105c313179526fe43585b78cf1156e1f0d9
Origin: #1
Forwarded: noble#851
Signed-off-by: Philippe Coval <p.coval@samsung.com>
This was referenced Feb 20, 2020
Merged
Open
@rzr
Copy link
Author

rzr commented Feb 20, 2020 •
edited
Loading

You can review changes individually:

#851

Once merged I will rebase on upstream and forward a 2d batch

Is there anyone else I should contact?

https://twitter.com/RzrFreeFr/status/1230527541938618368

Status to be updated at:

abandonware#2

@rzr rzr mentioned this pull request Feb 23, 2020
Open
@rzr rzr force-pushed the sandbox/rzr/upstream/review/master branch from 9770cfe to cb5e610 Compare April 3, 2020 16:57
@rzr rzr mentioned this pull request May 14, 2020
Open
CyberCastle
CyberCastle approved these changes May 15, 2020
View reviewed changes
Copy link

@CyberCastle CyberCastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a quickling test, I don't found issues.

@rzr
Copy link
Author

rzr commented May 15, 2020

Can @opencollective tell us what to do in this situation ?

@rzr rzr mentioned this pull request May 22, 2020
Open
@rzr
Copy link
Author

rzr commented Sep 6, 2020

Relate-to: #923 (comment)

@rzr
Copy link
Author

rzr commented Sep 17, 2020 •
edited
Loading

Is anyone in touch with upstream authors ?

Thoses changes are also in:
https://www.npmjs.com/package/@abandonware/noble/v/1.9.2-10

@objectiveSee
Copy link

Hey! Curious what it takes to get this merged as well! Just started a new project and was confused by the two repos. I prefer Abandonwares version as it works better on my Macbook (install issues on Noble/Noble), plus the async support is really nice! Would be great to see this all cleaned up and organized better for the community! Thanks.

@objectiveSee
Copy link

FWIW, looks like the failing tests are all due to older Node versions that don't support arrow functions:

test/test-noble.js: line 2, col 1, 'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
test/test-noble.js: line 4, col 1, 'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
test/test-noble.js: line 6, col 20, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
test/test-noble.js: line 10, col 3, 'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
test/test-noble.js: line 11, col 3, 'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
test/test-noble.js: line 13, col 15, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
test/test-noble.js: line 15, col 14, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
test/test-noble.js: line 16, col 12, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
test/test-noble.js: line 24, col 35, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
test/test-noble.js: line 25, col 38, 'async functions' is only available in ES8 (use 'esversion: 8').
test/test-noble.js: line 25, col 45, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
test/test-noble.js: line 26, col 7, 'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
test/test-noble.js: line 27, col 7, 'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
test/test-noble.js: line 28, col 7, 'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
test/test-noble.js: line 36, col 51, 'async functions' is only available in ES8 (use 'esversion: 8').
test/test-noble.js: line 36, col 58, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
test/test-noble.js: line 37, col 7, 'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
test/test-noble.js: line 44, col 26, 'async functions' is only available in ES8 (use 'esversion: 8').
test/test-noble.js: line 44, col 33, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
test/test-noble.js: line 45, col 7, 'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
test/test-noble.js: line 53, col 34, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
test/test-noble.js: line 54, col 38, 'async functions' is only available in ES8 (use 'esversion: 8').
test/test-noble.js: line 54, col 45, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
test/test-noble.js: line 56, col 7, 'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
test/test-noble.js: line 63, col 26, 'async functions' is only available in ES8 (use 'esversion: 8').
test/test-noble.js: line 63, col 33, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
test/test-noble.js: line 64, col 7, 'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
27 errors
npm ERR! Test failed.  See above for more details.
The command "npm test" exited with 1.

rzr and others added 13 commits January 26, 2021 13:14
@rzr
travis: Add node-10 remove 0.8
742a58c 
Change-Id: I96b7572a1872691dab80af70f1ebc811a50438fb
Origin: #1
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@rzr
travis: Drop node-4 and earlier
ae18609 
Origin: #1
Change-Id: I8eb04badb5ee427dab37e314fb43114f805f8064
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@rzr
npm: Drop node-4 and earlier
d15d465 
Origin: #1
Change-Id: Iab54f45109bb4a11e172f9d9de784a0d9d436766
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@n3rd4i @rzr
usage update
7c79750
@rzr
Typo fix
7af9c28 
Change-Id: Ice06fce18ced8cea9ed8fb87721f9de2c9c50c83
Forwarded: noble#818
@thegecko @rzr
Add types from DefinitelyTyped
d4b1561
@svogl @rzr
add try/catch around region affected by buffer overflow
6e0ee09 
if eirLength fields are corrupted. This happens on some firmwares that send out multiple advertisements but do not fix the length fields (which eventually causes kernel panics as well).

Change-Id: Ia88ca5a3ae583afa06ffdd11cefc86938163a36e
Relate-to: #28
@svogl @rzr
added events for service and characteristics discovery
a352631 
(serviceDiscovered, characteristicsDiscovered) that enables
caching of gatt information.
The cached objects can be used to initialize a device via addServices() and addCharacteristics(), which return an
array of Noble objects ready for connecting in the usual way.

examples/cache-gatt-discovery.js provides an example for collecting GATT data and persisting the information,
examples/cache-gatt-reconnect.js uses the data to connect to the device using the cached data.

Author: Simon Vogl <simon@voxel.at>
Relate-to: #29
Change-Id: I68bc5208529f872e5f60d7c0315a6346d24df2fb
@mwohlert @rzr
Added MTU value to peripheral on successful handshake
201adc2 
Authored by: EricDobyns
@akx @rzr
Fix use-before-assign
b89e99d
@rsmeral @rzr
Add peripheral-explorer-async example
6ac634d
@rsmeral @rzr
Update README to describe Promise-based methods
a545720
@rsmeral @rzr
add tests for async functions of noble
cec81cc
@rzr rzr force-pushed the sandbox/rzr/upstream/review/master branch from cb5e610 to cec81cc Compare January 26, 2021 12:15
@rzr
Copy link
Author

rzr commented Jan 26, 2021

I have updated the serie
may reviewing start with this single patch:
#851

This was referenced Mar 30, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@rzr
Copy link
Author

rzr commented Sep 25, 2021

Please merge #851

Or provide feedback at:
abandonware#2

@rzr
Copy link
Author

rzr commented Nov 29, 2022

If this project is no more maintained please let it know in readme file ?

The other option would be to transfer maintenance to @abandonware community best effort

https://purl.org/rzr/abandonware

Cc: @sandeepmistry

@rzr
Copy link
Author

rzr commented Feb 7, 2023

Hi is there any hope to co-maintain noble ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberCastle CyberCastle CyberCastle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@rzr @objectiveSee @CyberCastle @n3rd4i @thegecko @svogl @mwohlert @akx @rsmeral