Cannot install on node 10 #84

kounch · 2018-05-06T09:01:59Z

(...) In file included from ../src/BluetoothHciSocket.cpp:8:0: ../../nan/nan.h:950:46: nota: se declara aquí NAN_DEPRECATED inline v8::Local<v8::Value> MakeCallback( ^~~~~~~~~~~~ ../src/BluetoothHciSocket.cpp: En la función miembro void BluetoothHciSocket::emitErrnoError(): ../src/BluetoothHciSocket.cpp:275:72: error: no matching function for call to v8::Function::NewInstance(int, v8::Local<v8::Value> [1]) Local<Value> error = errorConstructor->NewInstance(1, constructorArgs); (...)

Possibly related to old nan dependency, like is mentioned here:

agnat/node_mdns#210

The text was updated successfully, but these errors were encountered:

mogenson · 2018-05-07T20:12:39Z

On Linux x86_64 with nodejs 10.0.0-1

In file included from ../src/BluetoothHciSocket.cpp:8:0:
../../nan/nan.h:950:46: note: declared here
   NAN_DEPRECATED inline v8::Local<v8::Value> MakeCallback(
                                              ^~~~~~~~~~~~
make: *** [binding.target.mk:95: Release/obj.target/binding/src/BluetoothHciSocket.o] Error 1
make: Leaving directory '/path/to/my/node/project/node_modules/bluetooth-hci-socket/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:225:12)
gyp ERR! System Linux 4.16.7-1-MANJARO
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/mike/Scansorial/root-bootloader/xsquare/node_modules/bluetooth-hci-socket
gyp ERR! node -v v10.0.0
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok

kounch · 2018-05-25T06:08:20Z

After some tests, it looks like making these two changes solve the problem:

File src/BluetoothHciSocket.cpp, change line 276 from
Local<Value> error = errorConstructor->NewInstance(1, constructorArgs);
to
Local<Value> error = Nan::NewInstance(errorConstructor, 1, constructorArgs).ToLocalChecked();

File package.json, change line 30 from
"nan": "^2.0.5",
to
"nan": "^2.10.0",

airhorns · 2018-06-01T22:12:45Z

I'm also getting this error and can confirm downgrading to node 8.11.1 fixed my issue. My full build log:

[main]  info This module is OPTIONAL, you can safely ignore this error
[main]  warning Error running install script for optional dependency: "/node_modules/bluetooth-hci-socket: Command failed.
[main]  Exit code: 1
[main]  Command: node-gyp rebuild
[main]  Arguments:
[main]  Directory: /node_modules/bluetooth-hci-socket
[main]  Output:
[main]  gyp info it worked if it ends with ok
[main]  gyp info using node-gyp@3.6.2
[main]  gyp info using node@10.0.0 | linux | arm
[main]  gyp info spawn /usr/bin/python2
[main]  gyp info spawn args [ '/usr/local/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
[main]  gyp info spawn args   'binding.gyp',
[main]  gyp info spawn args   '-f',
[main]  gyp info spawn args   'make',
[main]  gyp info spawn args   '-I',
[main]  gyp info spawn args   '/node_modules/bluetooth-hci-socket/build/config.gypi',
[main]  gyp info spawn args   '-I',
[main]  gyp info spawn args   '/usr/local/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
[main]  gyp info spawn args   '-I',
[main]  gyp info spawn args   '/root/.node-gyp/10.0.0/include/node/common.gypi',
[main]  gyp info spawn args   '-Dlibrary=shared_library',
[main]  gyp info spawn args   '-Dvisibility=default',
[main]  gyp info spawn args   '-Dnode_root_dir=/root/.node-gyp/10.0.0',
[main]  gyp info spawn args   '-Dnode_gyp_dir=/usr/local/lib/node_modules/npm/node_modules/node-gyp',
[main]  gyp info spawn args   '-Dnode_lib_file=/root/.node-gyp/10.0.0/<(target_arch)/node.lib',
[main]  gyp info spawn args   '-Dmodule_root_dir=/node_modules/bluetooth-hci-socket',
[main]  gyp info spawn args   '-Dnode_engine=v8',
[main]  gyp info spawn args   '--depth=.',
[main]  gyp info spawn args   '--no-parallel',
[main]  gyp info spawn args   '--generator-output',
[main]  gyp info spawn args   'build',
[main]  gyp info spawn args   '-Goutput_dir=.' ]
[main]  gyp info spawn make
[main]  gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
[main]  make: Entering directory '/node_modules/bluetooth-hci-socket/build'
[main]    CXX(target) Release/obj.target/binding/src/BluetoothHciSocket.o
[main]  ../src/BluetoothHciSocket.cpp: In member function ‘void BluetoothHciSocket::poll()’:
[main]  ../src/BluetoothHciSocket.cpp:251:95: warning: ‘v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::String>, int, v8::Local<v8::Value>*)’ is deprecated (declared at ../../nan/nan.h:950) [-Wdeprecated-declarations]
[main]       Nan::MakeCallback(Nan::New<Object>(this->This), Nan::New(\"emit\").ToLocalChecked(), 2, argv);
[main]                                                                                                 ^
[main]  ../src/BluetoothHciSocket.cpp: In member function ‘void BluetoothHciSocket::emitErrnoError()’:
[main]  ../src/BluetoothHciSocket.cpp:275:72: error: no matching function for call to ‘v8::Function::NewInstance(int, v8::Local<v8::Value> [1])’
[main]     Local<Value> error = errorConstructor->NewInstance(1, constructorArgs);
[main]                                                                          ^
[main]  ../src/BluetoothHciSocket.cpp:275:72: note: candidates are:
[main]  In file included from /root/.node-gyp/10.0.0/include/node/node.h:63:0,
[main]                   from /root/.node-gyp/10.0.0/include/node/node_buffer.h:25,
[main]                   from ../src/BluetoothHciSocket.cpp:7:
[main]  /root/.node-gyp/10.0.0/include/node/v8.h:3848:44: note: v8::MaybeLocal<v8::Object> v8::Function::NewInstance(v8::Local<v8::Context>, int, v8::Local<v8::Value>*) const
[main]     V8_WARN_UNUSED_RESULT MaybeLocal<Object> NewInstance(
[main]                                              ^
[main]  /root/.node-gyp/10.0.0/include/node/v8.h:3848:44: note:   candidate expects 3 arguments, 2 provided
[main]  /root/.node-gyp/10.0.0/include/node/v8.h:3851:44: note: v8::MaybeLocal<v8::Object> v8::Function::NewInstance(v8::Local<v8::Context>) const
[main]     V8_WARN_UNUSED_RESULT MaybeLocal<Object> NewInstance(
[main]                                              ^
[main]  /root/.node-gyp/10.0.0/include/node/v8.h:3851:44: note:   candidate expects 1 argument, 2 provided
[main]  ../src/BluetoothHciSocket.cpp:282:93: warning: ‘v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::String>, int, v8::Local<v8::Value>*)’ is deprecated (declared at ../../nan/nan.h:950) [-Wdeprecated-declarations]
[main]     Nan::MakeCallback(Nan::New<Object>(this->This), Nan::New(\"emit\").ToLocalChecked(), 2, argv);
[main]                                                                                               ^
[main]  binding.target.mk:93: recipe for target 'Release/obj.target/binding/src/BluetoothHciSocket.o' failed
[main]  make: *** [Release/obj.target/binding/src/BluetoothHciSocket.o] Error 1
[main]  make: Leaving directory '/node_modules/bluetooth-hci-socket/build'
[main]  gyp ERR! build error
[main]  gyp ERR! stack Error: `make` failed with exit code: 2
[main]  gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)
[main]  gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
[main]  gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:225:12)
[main]  gyp ERR! System Linux 4.12.13
[main]  gyp ERR! command \"/usr/local/bin/node\" \"/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js\" \"rebuild\"
[main]  gyp ERR! cwd /node_modules/bluetooth-hci-socket
[main]  gyp ERR! node -v v10.0.0
[main]  gyp ERR! node-gyp -v v3.6.2
[main]  gyp ERR! not ok"

ghost · 2018-06-18T05:34:32Z

@kounch : I submitted what you wrote as PR here: #91 , but you should probably submit it yourself. Once you do so, i'll delete this one.

AlCalzone · 2018-08-15T10:23:25Z

Any news on this? This prevents a couple of our projects to support Node 10.

rzr · 2018-11-08T07:58:27Z

Any progress on this ?
Now node-10 is LTS so I guess it is more than welcome.

Current workaround is:

npm install "https://github.com/jrobeson/node-bluetooth-hci-socket/#fix-builds-for-node-10" # worked

What is blocking ? I can help on it if needed...

Relate-to: WebThingsIO/gateway#1441

Apollon77 · 2018-11-26T11:55:09Z

Any news here? it is very important for all projects that care about full nodejs support or to use current versions! What is so problematic here?

ghost · 2018-11-26T11:58:57Z

there's nothing problematic. the maintainer is just not around.

ghost · 2018-11-26T11:59:15Z

I've considered forking it, but I haven't wanted to maintain it alone.

AlCalzone · 2018-11-26T12:48:27Z

there's nothing problematic. the maintainer is just not around.

That does sound kinda problematic ;)

rzr · 2018-11-26T13:39:29Z

Do you know existing github/npm team that could do co maintenance on this module ?

If none may I suggest to move this project to:
https://github.com/abandonware

ghost · 2018-11-26T22:04:12Z

@AlCalzone : i meant there's nothing problematic with the PR itself :)

barcating · 2018-11-29T08:00:56Z

I'm also getting this error.
/home/barcating/.node-gyp/11.3.0/include/node/v8config.h:326:3: note: in definition of macro ‘V8_DEPRECATED’
declarator attribute((deprecated(message)))
^
binding.target.mk:101: recipe for target 'Release/obj.target/binding/src/BluetoothHciSocket.o' failed
make: *** [Release/obj.target/binding/src/BluetoothHciSocket.o] Error 1
make: Leaving directory '/home/barcating/SDR/bluetooth/gattacker/node_modules/bluetooth-hci-socket/build'
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack at ChildProcess.emit (events.js:182:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)
gyp ERR! System Linux 4.13.0-36-generic
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/barcating/SDR/bluetooth/gattacker/node_modules/bluetooth-hci-socket
gyp ERR! node -v v11.3.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok

barcating · 2018-11-29T08:05:46Z

Any progress on this ?
Now node-10 is LTS so I guess it is more than welcome.

Current workaround is:
npm install "https://github.com/jrobeson/node-bluetooth-hci-socket/#fix-builds-for-node-10" # worked
What is blocking ? I can help on it if needed...

Relate-to: mozilla-iot/gateway#1441

Thanks！It worked.

rzr · 2018-11-29T09:19:46Z

So please vote for:
#91

Apollon77 · 2018-12-13T23:24:08Z

Hey All,

because also we are very dependent on this library I plan to do the following:
I will create a fork of this library, I am happy to accept node10 compatibility PRs on this fork and will then publish the node10 compatible version as "bluetooth-hci-socket2" to npm.

I will not accept feature additions, bugfixes we need to see because it's only for the node 10+ compatibility. I still hope that the original library gets a new maintainer that will continue the work or the original maintainer finds time again (no offense).

After the release all project that want can change their dep to the new library till the old is reactivated,

I post this here to get your opinion or objections against this idea, but we are blocked because of this.

So, what do you think?
Or do someone else want to do something like thin? ;-)

rzr · 2018-12-14T00:49:13Z

I forked it in:
https://github.com/abandonware/node-bluetooth-hci-socket
if anyone want to co maintain it let me know to and join the team

Then it could be released in NPM's org subrepo ?

This fix comes from noble#84 (comment) , so I can't personally vouch for it. Change-Id: Ifde2a3b996ab89a4b12b0eb155c081aca2b11dc3 Origin: https://github.com/jrobeson/node-bluetooth-hci-socket Forwarded: noble#91

Apollon77 · 2018-12-14T07:59:29Z

@rzr great idea! Thank you for taking the idea over! For NPM release I have no idea whats best.

BTW: In theory wealso would need to fork noble the same way because it is used there too and many users are directly using noble ... What do you think?

Apollon77 · 2018-12-14T08:00:46Z

@rzr: Who can activate travis/appveyor for this repo so that we still have tests? Or do we need to fix that with own repo forks?

rzr · 2018-12-14T09:27:17Z

I activated my travis for:
https://travis-ci.org/abandonware/node-bluetooth-hci-socket

Can you take care of appveyor ?

If there are other pendant relevant patches let it know at:

Then we'll see how to publish a fixed npm for node10:
#85

Apollon77 · 2018-12-14T09:33:41Z

I would need to be in the project to activate appveyor :-( Then you need to ssign me rights/invite me.
ELse Appveyor is also easy ... go https://appveyor.com and Login with Github and Add Project :-)

rzr · 2018-12-14T09:44:15Z

I invited you to join
https://github.com/orgs/abandonware/people

Apollon77 · 2018-12-14T09:51:14Z

Got nothing so far and link shows only that I can not see anything :-)

ghost · 2018-12-22T22:04:24Z

@th317erd : are you familiar with node's n-api? It'd be nice to convert the addon to n-api so the module will work across different node versions. We could go with plain C via n-api itself, or C++ via node-addon-api.

th317erd · 2018-12-23T18:03:52Z

No, I am not familiar with n-api, or V8 interfaces. However, I am good with C/C++, which is why I offered. I will take a look @rzr and @jrobeson when I get a free moment. @rzr was there anything specific you wanted me to test?

Abandonware namespace was used Update bluetooth-hci-socket for node-10 Relate-to: noble/node-bluetooth-hci-socket#84 Origin: #1 Change-Id: Ib32f0c00bb0e7dcb9a125261cd9db0d11c440c21 Signed-off-by: Philippe Coval <p.coval@samsung.com>

janhaa · 2019-09-16T23:32:58Z

Issue was just fixed in abandonware#5 :-)

rzr · 2019-09-17T12:40:42Z

And released To npm

maxbellec · 2019-11-14T14:47:19Z

npm install @abandonware/noble

works for me

rzr · 2019-11-14T14:54:23Z

Please also review:
#105
Then I will try to upstream more abandonware patches once this one is merged

Please review open PR to:
https://github.com/abandonware

Abandonware namespace was used Update bluetooth-hci-socket for node-10 Relate-to: noble/node-bluetooth-hci-socket#84 Origin: abandonware#1 Change-Id: Ib32f0c00bb0e7dcb9a125261cd9db0d11c440c21 Signed-off-by: Philippe Coval <p.coval@samsung.com>

rzr · 2021-01-06T13:05:13Z

Feel free to comment this related ticket:

abandonware#9

rzr · 2021-10-01T10:30:43Z

May you forward your ticket to downstream version if relevant or confirm @abandonware version match your requirements here:

#123

Liu-Jinshuai · 2023-09-12T10:15:59Z

npm i bleno2

You can try this. It works well on my Linux. It has not been tested on other platforms. I hope it will help you.

This was referenced Jun 18, 2018

noble installation fails for node version 10 on Linux noble/noble#805

Open

[WIP] Fix build on node 10.x #91

Closed

rzr mentioned this issue Oct 24, 2018

raspberrypi 3 B install error noble/bleno#389

Open

jdpigeon mentioned this issue Nov 4, 2018

Cannot find module 'bluetooth-hci-socket' makebrainwaves/BrainWaves#32

Closed

mhirsch mentioned this issue Dec 6, 2018

openbci-ganglion depends on bluetooth-hci-socket, which is abandoned and doesn't build with node 10 openbci-archive/OpenBCI_NodeJS_Ganglion#52

Open

rzr mentioned this issue Dec 14, 2018

Publish on npm #85

Open

hannseman mentioned this issue Jan 26, 2019

Node 10 support on linux Timeular/noble-mac#23

Closed

Bankaifan mentioned this issue Jan 28, 2019

Crashing on startup honkmaster/homebridge-mi-flower-care#2

Closed

dbaba mentioned this issue Feb 1, 2019

unable to install on rpi CANDY-LINE/node-red-contrib-generic-ble#14

Closed

nanosonde mentioned this issue Feb 11, 2019

noble not maintained anymore oyooyo/simble#1

Closed

trollkotze mentioned this issue Feb 12, 2019

build fails for node v10 MatthD/node-libxml#3

Closed

This was referenced Feb 20, 2019

Cannot install bleno with nodejs 10.x in a raspberry pi zero. V8_DEPRECATED error noble/bleno#425

Open

doesn't compile on RPi 3B+ #107

Open

Olindholm mentioned this issue Mar 11, 2019

Sphero Bolt Support igbopie/spherov2.js#20

Closed

This was referenced Apr 16, 2019

can not install on node 10 maxnowack/homebridge-eq3ble#24

Open

can not install on node 10 maxnowack/node-eq3ble#10

Open

zilluss mentioned this issue Jun 2, 2019

Use abandonwares noble fork henry-spanka/nubli#2

Open

ivesdebruycker mentioned this issue Jun 26, 2019

bluetooth-hci-socket not installing igbopie/spherov2.js#35

Closed

Jeija mentioned this issue Jul 22, 2019

BlueotoothHCI dont compile in linux. Jeija/bluefluff#45

Closed

akx mentioned this issue Aug 1, 2019

Can't start in Hass.io akx/hass-ruuvitag#4

Closed

bergie mentioned this issue Sep 13, 2019

Noble is unmaintained pakastin/node-ruuvitag#13

Closed

This was referenced Sep 16, 2019

node 12.8 - dependency @abandonware/bluetooth-hci-socket build fail abandonware/noble#21

Closed

Impossible to install noble noble/noble#901

Closed

giswa mentioned this issue Nov 4, 2019

homebridge-eq3ble / Bluetooth Support homebridge/docker-homebridge#165

Closed

guinmoon mentioned this issue Mar 24, 2020

Cannot install the plugin correctly guinmoon/homebridge-redmond-ms170s#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot install on node 10 #84

Cannot install on node 10 #84

kounch commented May 6, 2018

mogenson commented May 7, 2018

kounch commented May 25, 2018

airhorns commented Jun 1, 2018

ghost commented Jun 18, 2018

AlCalzone commented Aug 15, 2018

rzr commented Nov 8, 2018

Apollon77 commented Nov 26, 2018

ghost commented Nov 26, 2018

ghost commented Nov 26, 2018

AlCalzone commented Nov 26, 2018

rzr commented Nov 26, 2018

ghost commented Nov 26, 2018

barcating commented Nov 29, 2018

barcating commented Nov 29, 2018

rzr commented Nov 29, 2018

Apollon77 commented Dec 13, 2018

rzr commented Dec 14, 2018

Apollon77 commented Dec 14, 2018

Apollon77 commented Dec 14, 2018

rzr commented Dec 14, 2018

Apollon77 commented Dec 14, 2018

rzr commented Dec 14, 2018

Apollon77 commented Dec 14, 2018

ghost commented Dec 22, 2018

th317erd commented Dec 23, 2018

janhaa commented Sep 16, 2019 •

edited

Loading

rzr commented Sep 17, 2019

maxbellec commented Nov 14, 2019

rzr commented Nov 14, 2019

rzr commented Jan 6, 2021

rzr commented Oct 1, 2021

Liu-Jinshuai commented Sep 12, 2023

Cannot install on node 10 #84

Cannot install on node 10 #84

Comments

kounch commented May 6, 2018

mogenson commented May 7, 2018

kounch commented May 25, 2018

airhorns commented Jun 1, 2018

ghost commented Jun 18, 2018

AlCalzone commented Aug 15, 2018

rzr commented Nov 8, 2018

Apollon77 commented Nov 26, 2018

ghost commented Nov 26, 2018

ghost commented Nov 26, 2018

AlCalzone commented Nov 26, 2018

rzr commented Nov 26, 2018

ghost commented Nov 26, 2018

barcating commented Nov 29, 2018

barcating commented Nov 29, 2018

rzr commented Nov 29, 2018

Apollon77 commented Dec 13, 2018

rzr commented Dec 14, 2018

Apollon77 commented Dec 14, 2018

Apollon77 commented Dec 14, 2018

rzr commented Dec 14, 2018

Apollon77 commented Dec 14, 2018

rzr commented Dec 14, 2018

Apollon77 commented Dec 14, 2018

ghost commented Dec 22, 2018

th317erd commented Dec 23, 2018

janhaa commented Sep 16, 2019 • edited Loading

rzr commented Sep 17, 2019

maxbellec commented Nov 14, 2019

rzr commented Nov 14, 2019

rzr commented Jan 6, 2021

rzr commented Oct 1, 2021

Liu-Jinshuai commented Sep 12, 2023

janhaa commented Sep 16, 2019 •

edited

Loading