Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tests #1

Closed
wants to merge 2 commits into from
Closed

Fixed tests #1

wants to merge 2 commits into from

Conversation

screendriver
Copy link

No description provided.

@screendriver screendriver mentioned this pull request May 22, 2018
Closed
@noblica
Copy link
Owner

noblica commented May 22, 2018 •
edited
Loading

Hey, thanks for the PR, but as I said in the convo, using "module": "commonjs" with the "allowSyntheticDefaultImports": true flag, throws the same error. That flag is absent in your code.

However, if we keep both of these flags, and remove the enableTsDiagnostics flag from the package.json file, the tests works again. It's a bit strange.

Do you know why this happens?

@screendriver
Copy link
Author

I pushed fix #2 with allowSyntheticDefaultImports set to true

@screendriver screendriver closed this by deleting the head repository Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@screendriver @noblica