Add a converter specified shortcut #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a shortcut specified by RAW and Align Concverter.
|
Is concverter a real thing or a typo ? |
ccoVeille
reviewed
Sep 12, 2024
oviewer/oviewer.go
Outdated
Comment on lines
709
to
714
| if RawF { | ||
| root.General.Converter = convRaw | ||
| } | ||
| if AlignF { | ||
| root.General.Converter = convAlign | ||
| } |
There was a problem hiding this comment.
The logic is strange to read.
So AlignF "wins" vs RawF when present, right?
Maybe this?
Suggested change
| if RawF { | |
| root.General.Converter = convRaw | |
| } | |
| if AlignF { | |
| root.General.Converter = convAlign | |
| } | |
| if AlignF { | |
| root.General.Converter = convAlign | |
| } else if RawF { | |
| root.General.Converter = convRaw | |
| } |
oviewer/oviewer.go
Outdated
Comment on lines
376
to
380
| // RawF is specifies converter shortcut for raw. | ||
| var RawF bool | ||
|
|
||
| // AlignF is specifies converter shortcut for align. | ||
| var AlignF bool |
There was a problem hiding this comment.
Suggested change
| // RawF is specifies converter shortcut for raw. | |
| var RawF bool | |
| // AlignF is specifies converter shortcut for align. | |
| var AlignF bool | |
| // RawF specifies converter shortcut for raw. | |
| var RawF bool | |
| // AlignF specifies converter shortcut for align. | |
| var AlignF bool |
oviewer/oviewer.go
Outdated
Comment on lines
376
to
380
| // RawF is specifies converter shortcut for raw. | ||
| var RawF bool | ||
|
|
||
| // AlignF is specifies converter shortcut for align. | ||
| var AlignF bool |
There was a problem hiding this comment.
I don't think you need tgem to be exported
oviewer/oviewer.go
Outdated
Comment on lines
709
to
714
| if RawF { | ||
| root.General.Converter = convRaw | ||
| } | ||
| if AlignF { | ||
| root.General.Converter = convAlign | ||
| } |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you for your comment.
I moved to the main side and fixed it.
Typo. I will fix it. |
noborus
changed the title
Transferred shortcut handling for align and raw from oviewer/oviewer.go to main.go.
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 22, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [noborus/ov](https://github.com/noborus/ov) | minor | `v0.36.0` -> `v0.37.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>noborus/ov (noborus/ov)</summary> ### [`v0.37.0`](https://github.com/noborus/ov/releases/tag/v0.37.0) [Compare Source](noborus/ov@v0.36.0...v0.37.0) #### What's Changed Thank you for working on this release. [@​aoyama-val](https://github.com/aoyama-val) [@​ccoveille](https://github.com/ccoveille) [@​kapji](https://github.com/kapji) [@​yosagi](https://github.com/yosagi) [@​bprb](https://github.com/bprb) ##### Add a converter Escape sequence support has been changed from essential to selectable as a converter. There are converters: an interpretation of escape sequence (default), `raw`, which does not interpret escape sequence, and `align`. The columns can be shrinked, if the converter is aligned. noborus/ov#609 noborus/ov#610 noborus/ov#611 noborus/ov#612 noborus/ov#614 noborus/ov#615 noborus/ov#617 noborus/ov#618 noborus/ov#619 noborus/ov#623 noborus/ov#624 noborus/ov#625 noborus/ov#626 noborus/ov#627 noborus/ov#631 ##### Change specifications of suspend The suspend is suspended correctly, not sub-shell. Thank you to [@​yosagi](https://github.com/yosagi). - Change to suspend with SIGSTOP by [@​noborus](https://github.com/noborus) in noborus/ov#632 - Send SIGSTOP to the process group by [@​noborus](https://github.com/noborus) in noborus/ov#639 - STDIN switching when using Subshell by [@​noborus](https://github.com/noborus) in noborus/ov#640 ##### Changed redirect specifications - Change to Do not display screen when redirecting by [@​noborus](https://github.com/noborus) in noborus/ov#638 (Fix noborus/ov#634). ##### Fix bugs and improvements - Fix paste mistakes by [@​noborus](https://github.com/noborus) in noborus/ov#616 (Fix noborus/ov#613) - Avoid sector header when marking by [@​noborus](https://github.com/noborus) in noborus/ov#621 (Fix noborus/ov#620) - Change the style-related function name by [@​noborus](https://github.com/noborus) in noborus/ov#628 - help descriptions for better clarity by [@​noborus](https://github.com/noborus) in noborus/ov#635 - Fix the issue where the version contains "-1" by [@​noborus](https://github.com/noborus) in noborus/ov#637 Fix noborus/ov#636) - Fixed root.searcher is race condition by [@​noborus](https://github.com/noborus) in noborus/ov#642 (Fix noborus/ov#641) - Fix linkage of filter documents with headers by [@​noborus](https://github.com/noborus) in noborus/ov#644 - Improve follow/followAll/followSection by [@​noborus](https://github.com/noborus) in noborus/ov#645 - Add support of ANSI escape sequence for clear line by [@​noborus](https://github.com/noborus) in noborus/ov#651 (Fix noborus/ov#650) **Full Changelog**: noborus/ov@v0.36.0...v0.37.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a shortcut specified by RAW and Align converter.