Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multiple queries #14

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Added support for multiple queries #14

merged 1 commit into from
Dec 17, 2023

Conversation

noborus
Copy link
Owner

@noborus noborus commented Dec 17, 2023

Added support for multiple queries.
This makes UPDATE queries executable.

Summary by CodeRabbit

  • New Features

    • Enhanced xlsxsql tool to support execution of multiple queries, including update operations, providing more advanced manipulation of Excel files.
  • Documentation

    • Updated README to reflect new multi-query capabilities in xlsxsql tool.

Added support for multiple queries.
This makes UPDATE queries executable.
Copy link

coderabbitai bot commented Dec 17, 2023

Walkthrough

The xlsxsql tool has been enhanced to support the execution of multiple queries, including update operations, culminating in a SELECT query for output. This upgrade transforms the tool into a more robust platform capable of handling intricate Excel file manipulations akin to database transactions.

Changes

File(s) Change Summary
README.md Introduced multi-query execution feature for xlsxsql tool.
cmd/.../query.go Added function to enable multiple queries in exec function.

Poem

🐰🎉
Oh, data in rows and columns so bright,
Now dance with queries into the night.
Update, select, in harmony they weave,
A rabbit's code, in Excel, we believe. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between dfb39ff and ed91daa.
Files ignored due to filter (2)
  • go.mod
  • go.sum
Files selected for processing (2)
  • README.md (1 hunks)
  • cmd/query.go (1 hunks)
Additional comments: 2
README.md (1)
  • 247-255: The new section on multiple queries is clear and provides an example of how to use the update feature followed by a select query for output. This is a good addition to the documentation as it helps users understand the new capabilities of the tool.
cmd/query.go (1)
  • 16-16: Please verify if trdsql.EnableMultipleQueries() returns an error and consider adding error handling if necessary. This is important to ensure that any issues with enabling multiple queries are caught and handled gracefully.

@noborus noborus merged commit 44caec1 into main Dec 17, 2023
1 check passed
@noborus noborus deleted the multiple-queries branch December 17, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant