Multibyte product title fix from Shopify/hydrogen#1209

nobu-shopify · Aug 14, 2023 · 0c967dd · 0c967dd
1 parent eec8b22
commit 0c967dd
Show file tree

Hide file tree

Showing 2 changed files with 12,006 additions and 1 deletion.
diff --git a/app/routes/($locale).products.$productHandle.jsx b/app/routes/($locale).products.$productHandle.jsx
@@ -110,7 +110,11 @@ function redirectToFirstVariant({product, request}) {
     searchParams.set(option.name, option.value);
   }
 
-  throw redirect(`/products/${product.handle}?${searchParams.toString()}`, 302);
+//  throw redirect(`/products/${product.handle}?${searchParams.toString()}`, 302);
+  // Fix from https://github.com/Shopify/hydrogen/issues/1209
+  // Use URL to avoid accidental double encoding
+  const newUrl = new URL(`/products/${product.handle}?${searchParams.toString()}`, 'http://example.com');
+  throw redirect(newUrl.pathname + newUrl.search, 302);
 }
 
 export default function Product() {