Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix GPS plugin coordinate #1

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

achille-martin
Copy link
Collaborator

According to uuvsimulator#390, Gazebo is publishing -East -North Up instead of East North Up.

UUV Simulator handled this case by adding a minus sign to lat / lon in the GPS ROS Plugin.

However, this approach makes the creation of a .world confusing, as the origin of the world must have negative lat / lon.

The temporary solution (until Gazebo fixes its frame output according to gazebosim/gazebo-classic#2022 (comment)) is:

<!-- In the .world file -->
<spherical_coordinates>
      <!-- currently gazebo has a bug: instead of outputing lat, long, altitude in ENU
      (x = East, y = North and z = Up) as the default configurations, it's outputting (-E)(-N)U,
      therefore we rotate the default frame 180 so that it would go back to ENU -->
      <heading_deg>180</heading_deg>
  </spherical_coordinates>

@achille-martin achille-martin changed the title Removed minus sign from GPS ROS Plugin Bugfix GPS plugin coordinate Jun 18, 2024
…format instead of -E -U N format from Gazebo
@achille-martin achille-martin merged commit ef97923 into master Aug 8, 2024
@achille-martin achille-martin deleted the bug_fix_gps_plugin_coordinate branch August 8, 2024 10:27
@achille-martin
Copy link
Collaborator Author

For information, this MR coincides with OCSv3.12.0 (it introduces breaking changes for old versions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants