Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] properties for events to be generated do not seem to have an impact anymore #63

Closed
flexwende opened this issue Sep 21, 2023 · 5 comments

Comments

@flexwende
Copy link

flexwende commented Sep 21, 2023

The properties that define which event get generated do not seem to have an impact anymore. All events seem to be captured regardless of the property. E.g. even though my config looks like below all events get captured (tested: insert, update, delete, truncate).

timescaledb.hypertables.excludes = []
timescaledb.hypertables.includes = ['public.event_table']
timescaledb.events.read = false
timescaledb.events.insert = false
timescaledb.events.update = false
timescaledb.events.delete = false
timescaledb.events.truncate = false
timescaledb.events.message = false
timescaledb.events.compression = false
timescaledb.events.decompression = false

postgresql.tables.excludes = []
postgresql.tables.includes = []
postgresql.events.read = false
postgresql.events.insert = false
postgresql.events.update = false
postgresql.events.delete = false
postgresql.events.truncate = false
postgresql.events.message = false

Versions:

  • postgresql: 14
  • timescaledb: 2.11.2
  • timescaledb-event-streamer: 0.10.0
@noctarius
Copy link
Owner

I think it actually never worked 🤔

@flexwende
Copy link
Author

seems so. I also tested it with 0.9.2, same behaviour

@noctarius
Copy link
Owner

Yeah, false is the zero value for a bool. Fix already works. Fixed also a few more locations. When the tests finished, I'll merge and kick of a new release build.

noctarius added a commit that referenced this issue Sep 21, 2023
Fixes #63 Event property configuration is ignored
@noctarius
Copy link
Owner

Release finished. Thanks for the bug report 🙏

@flexwende
Copy link
Author

Nice, thanks for your work! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants