Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync flags to sdxl-scripts repo #786

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Sync flags to sdxl-scripts repo #786

merged 7 commits into from
Jul 23, 2024

Conversation

saienduri
Copy link
Contributor

@saienduri saienduri commented Jul 22, 2024 •
edited
Loading

Sync flags to sdxl-scripts repo

@saienduri saienduri requested a review from monorimet July 22, 2024 21:13
monorimet
monorimet approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@monorimet monorimet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really the direction we should be continuing in for managing these things, but for this week let's make it work and think about how to avoid all this yucky python spaghetti for compile flags.

I believe we spoke at some point about having a versioned repository of flagfiles to carry these things -- even if it ends up being "more redundant" to have one-shot configs I'd rather that than use model names in the flags generator.

Putting a bookmark in this so we can revisit after this week.

@monorimet
Copy link
Contributor

filed #787.

The CI failure is related to another patch, should be an easy fix to avoid running os.path.exists() on NoneType

@saienduri
Copy link
Contributor Author

Yeah I fully agree. Felt like the configuration process here was getting too messy while updating

@monorimet monorimet merged commit d857f77 into bump-punet Jul 23, 2024
2 of 3 checks passed
@monorimet monorimet deleted the bump-punet-flags-sync branch July 23, 2024 15:06
@vivekkhandelwal1 vivekkhandelwal1 mentioned this pull request Aug 14, 2024
Closed
monorimet pushed a commit that referenced this pull request Nov 6, 2024
@saienduri @eagarvey-amd
Sync flags to sdxl-scripts repo (#786)
3967465 
Sync flags to sdxl-scripts repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monorimet monorimet monorimet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saienduri @monorimet