Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update opset version to 21 when importing onnx models #329

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Update opset version to 21 when importing onnx models #329

merged 1 commit into from
Aug 20, 2024

Conversation

jinchen62
Copy link
Contributor

@jinchen62 jinchen62 commented Aug 20, 2024 •
edited
Loading

@jinchen62 jinchen62 requested a review from zjgarvey August 20, 2024 21:00
zjgarvey
zjgarvey approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem reasonable to me, but I'm sure there will be some models that fail to update to version 21 properly.

@zjgarvey
Copy link
Contributor

Also, please change the title to something reflective of the change. E.g., "update opset version to 21 when importing"

@jinchen62 jinchen62 changed the title Fix shape inference when importing models Update opset version to 21 when importing onnx models Aug 20, 2024
@jinchen62 jinchen62 merged commit 0fff0b9 into nod-ai:main Aug 20, 2024
@jinchen62 jinchen62 deleted the alt_e2e branch August 20, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjgarvey zjgarvey zjgarvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinchen62 @zjgarvey