Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO MERGE] iree-amd-aie patches #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

makslevental
Copy link

No description provided.

@@ -7,7 +7,7 @@ add_subdirectory(xdp)
if(CMAKE_VERSION VERSION_LESS "3.18.0")
message(WARNING "CMake version is less than 3.18.0, build of submodule aiebu disabled")
elseif (${XRT_NATIVE_BUILD} STREQUAL "yes")
add_subdirectory(aiebu)
# add_subdirectory(aiebu)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without commenting this line, we will see error like below:

-- building XRT core libs
-- CMAKE_SYSTEM=Windows-10.0.27723
-- CMAKE_INSTALL_PREFIX=C:/develop/iree-amd-aie-dezhi/iree-build/compiler/plugins/iree-aie-xrt-coreutil/aiebu/xilinx
-- Using aie-rt from C:/develop/iree-amd-aie-dezhi/iree-build/compiler/plugins/iree-aie-xrt-coreutil/aiebu
-- Using ELFIO from C:/develop/iree-amd-aie-dezhi/third_party/XRT/src/runtime_src/core/common/aiebu/src/cpp/ELFIO
-- Found Python3: C:/Python313/python.exe (found version "3.13.0") found components: Interpreter
-- Python version: 3.13.0
-- Could NOT find Boost (missing: Boost_INCLUDE_DIR)
-- Boost version:
CMake Error at C:/Program Files/Microsoft Visual Studio/2022/Professional/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
Could NOT find Boost (missing: Boost_INCLUDE_DIR program_options)
Call Stack (most recent call first):
C:/Program Files/Microsoft Visual Studio/2022/Professional/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
C:/Program Files/Microsoft Visual Studio/2022/Professional/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.27/Modules/FindBoost.cmake:2378 (find_package_handle_standard_args)
C:/develop/iree-amd-aie-dezhi/third_party/XRT/src/runtime_src/core/common/aiebu/src/cpp/aiebu/CMakeLists.txt:7 (find_package)

@@ -19,7 +19,7 @@

#include <boost/format.hpp>

#include <stdexcept>
#include <any>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What justify this change is not clear

@dezhiAmd
Copy link

This PR is already merged, please refer here:
a9fdf61#diff-042dcf9f51a9fa0f5cf06bd4c756863209701ba217de8acc7546f0794327c2eeR10

@makslevental
Copy link
Author

makslevental commented Nov 12, 2024

I have no clue what you're doing nor what you're trying to communicate

This PR is already merged, please refer here: a9fdf61#diff-042dcf9f51a9fa0f5cf06bd4c756863209701ba217de8acc7546f0794327c2eeR10

this PR isn't merged (you're commenting on the open PR right now...)

What justify this change is not clear

I have no idea what you're trying to accomplish so I'm not gonna spend time explaining to you every little piece of the enormous amount of work it takes to build XRT for iree-amd-aie's use case. Especially since XRT is deprecated in iree-amd-aie.

So you can either explain what you're trying to accomplish and then I will comment on that goal or you can figure it out by yourself.

@dezhiAmd
Copy link

I have no clue what you're doing nor what you're trying to communicate

This PR is already merged, please refer here: a9fdf61#diff-042dcf9f51a9fa0f5cf06bd4c756863209701ba217de8acc7546f0794327c2eeR10

this PR isn't merged (you're commenting on the open PR right now...)

What justify this change is not clear

I have no idea what you're trying to accomplish so I'm not gonna spend time explaining to you every little piece of the enormous amount of work it takes to build XRT for iree-amd-aie's use case. Especially since XRT is deprecated in iree-amd-aie.

So you can either explain what you're trying to accomplish and then I will comment on that goal or you can figure it out by yourself.

Can we talk offline? If yes, do you prefer teams or slack?

@makslevental
Copy link
Author

Can we talk offline? If yes, do you prefer teams or slack?

No I prefer for technical discussions to remain in the open for everyone to refer to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants