-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Track performance numbers on a webpage #1035
Conversation
432b6d5
to
9d71481
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plot looks nice. Thanks for developing this!
I think this is a good start point for performance tracking. We can gradually optimize this once we look at the graph with more commits history. Just one trivial comment.
results_html_path = sys.argv[3] | ||
|
||
# Get the results for the current run. | ||
with open(results_json_path, "r") as f: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to put everything below this to a separate function. And the main only check the arguments and call the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
if len(sys.argv) != 4: | ||
print( | ||
"Usage: python3 performance_publish.py <path_to_results_json> <path_to_results_history> <path_to_results_html>\n" | ||
"This script reads the performance results from the specified JSON file, appends them to the history file, and generates an HTML visualizarion.\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This script reads the performance results from the specified JSON file, appends them to the history file, and generates an HTML visualizarion.\n" | |
"This script reads the performance results from the specified JSON file, appends them to the history file, and generates an HTML visualization.\n" |
The workflow: - run performance benchmarks the same way as before, generating `performance.log` - convert `performance.log` into `results.json` - switch to the `gh-pages` branch - append the new `results.json` data to `results_history.json` - create `results_history.html` based on the updated `results_history.json` (only when CI is triggered from the `main` branch) - commit the updated `results_history.json` and `results_history.html` using the action bot To preview what it looks like: [https://rawcdn.githack.com/nod-ai/iree-amd-aie/a70ddbeea9d0b0d14f8ab24208efc599bc3c2f39/results_history.html](https://rawcdn.githack.com/nod-ai/iree-amd-aie/a70ddbeea9d0b0d14f8ab24208efc599bc3c2f39/results_history.html) I don’t have access to set up the webpage for this repository, but once the `gh-pages` branch is properly configured, the webpage shall be live on [https://nod-ai.github.io/iree-amd-aie/results_history.html](https://nod-ai.github.io/iree-amd-aie/results_history.html)
@Yu-Zhewen This site doesn't seem to be live: https://nod-ai.github.io/iree-amd-aie/results_history.html |
Some additional setup is required to configure the I don’t have the necessary access to make this change. Could someone with the appropriate permissions assist? |
The workflow:
performance.log
performance.log
intoresults.json
gh-pages
branchresults.json
data toresults_history.json
results_history.html
based on the updatedresults_history.json
(only when CI is triggered from the
main
branch)results_history.json
andresults_history.html
using the action botTo preview what it looks like: https://rawcdn.githack.com/nod-ai/iree-amd-aie/a70ddbeea9d0b0d14f8ab24208efc599bc3c2f39/results_history.html
I don’t have access to set up the webpage for this repository, but once the
gh-pages
branch is properly configured, the webpage shall be live on https://nod-ai.github.io/iree-amd-aie/results_history.html