-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A pass to add noalias
to function arguments, when safe
#1081
Conversation
769aa15
to
1b88de4
Compare
void AMDAIENoAliasFunctionArgumentsPass::runOnOperation() { | ||
Operation *op = getOperation(); | ||
|
||
// TODO(newling): resolve numerical issues on strix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an issue with peano and/or chess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, I'm trying to understand the issue. With peano.
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIENoAliasFunctionArguments.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIENoAliasFunctionArguments.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIENoAliasFunctionArguments.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIENoAliasFunctionArguments.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIENoAliasFunctionArguments.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIENoAliasFunctionArguments.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIENoAliasFunctionArguments.cpp
Outdated
Show resolved
Hide resolved
5479002
to
d3b755c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Replaces #1006. From #1006 :
This new PR addresses improves #1006 by making a pass that determines when it safe to add
noalias
rather than expecting the user to enable/disable adding the attribute.This new PR results in numerical failure on strix, so the pass is disables for strix for now.