-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not serialize-deserialize module before calling aie2xclbin #685
Conversation
100% agreed. I recommend you xfail (for a moment) those failing tests to see if this will work e2e. |
2d2793f
to
ef2efb7
Compare
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/AIETarget.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/XCLBinGen.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/XCLBinGen.cpp
Outdated
Show resolved
Hide resolved
3a8534e
to
a5b7010
Compare
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/Passes.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/XCLBinGen.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/XCLBinGen.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/XCLBinGen.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/XCLBinGen.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good but a couple of small questions/nits.
a5b7010
to
fbf482e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks for this change (it's a small but important one). Sorry for the hassle :(
47b12ed
to
cf909f3
Compare
cf909f3
to
a7219d9
Compare
This PR does a few things, happy to split it up if requested.
Before pulling mlir-aie into iree-amd-aie, it we required to serialize-deserialize to call the aie2xclbin program. But we now just use aie2xclbin as a function, no shell out anymore. So no serialization-deserialization needed.
This PR moves dma-to-npu closer to lower-to-aie pass. I think we'd eventually like to change the lowering of npu instructions from
to
, because the amdaie and aie dialects are very similar and this indirection doesn't provide us with anything afaict. Making that change is currently not possible (dma-to-npu must currently run after stateful transform pass), this change is a step in that direction though
Test changes: I removed some CHECKs for
aiex.runtime_sequence
in tests/samples, because that's now sucked into the LX instructions (sequence of integers). In my mind the tests in tests/samples are only useful to check that compilation doesn't error/crash, so IMO removing CHECK lines there is fine.