Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't capture this unnecessarily #818

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Don't capture this unnecessarily #818

merged 1 commit into from
Oct 2, 2024

Conversation

newling
Copy link
Contributor

@newling newling commented Oct 2, 2024

Introduced and unaddressed in #812

makslevental
makslevental approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@makslevental makslevental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title sounds like a lyric from a 2000s boyband song lol

@newling newling merged commit aae7cc6 into nod-ai:main Oct 2, 2024
6 checks passed
@yzhang93
Copy link
Contributor

yzhang93 commented Oct 2, 2024

I added "this" because it didn't pass the options correctly to the rewritter function in my first attempt with the change. But I guess some other changes fixed it and now it works without passing "this"! Thanks for making the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makslevental makslevental makslevental approved these changes

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@nirvedhmeshram nirvedhmeshram Awaiting requested review from nirvedhmeshram nirvedhmeshram is a code owner

@yzhang93 yzhang93 Awaiting requested review from yzhang93 yzhang93 is a code owner

@Abhishek-Varma Abhishek-Varma Awaiting requested review from Abhishek-Varma Abhishek-Varma is a code owner

@jtuyls jtuyls Awaiting requested review from jtuyls jtuyls is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newling @yzhang93 @makslevental