Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LowerToAIE] Make DMA creation sizes and strides static as early as possible #999

Merged
merged 1 commit into from
Dec 20, 2024
Merged

[LowerToAIE] Make DMA creation sizes and strides static as early as possible #999

merged 1 commit into from
Dec 20, 2024

Conversation

jtuyls
Copy link
Collaborator

@jtuyls jtuyls commented Dec 20, 2024

Refactor createDMA and convertSizeStrideToBDDimLayoutArrayAttr to simplify the logic.

yzhang93
yzhang93 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@yzhang93 yzhang93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtuyls jtuyls merged commit 1266a9f into nod-ai:main Dec 20, 2024
7 checks passed
@jtuyls jtuyls deleted the refactor-create-dma branch December 20, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhang93 yzhang93 yzhang93 approved these changes

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@nirvedhmeshram nirvedhmeshram Awaiting requested review from nirvedhmeshram nirvedhmeshram is a code owner

@Abhishek-Varma Abhishek-Varma Awaiting requested review from Abhishek-Varma Abhishek-Varma is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtuyls @yzhang93