[IREE EP] Fix ElementsAttr iteration error from MLIR. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinayakdsci
requested review from
stellaraccident,
Shukla-Gaurav,
kumardeepakamd and
zjgarvey
and removed request for
stellaraccident
stellaraccident
approved these changes
Sep 19, 2024
onnxruntime/core/providers/iree/compiler/torch-mlir-import-onnx/OnnxImporter.cpp
Show resolved
Hide resolved
onnxruntime/core/providers/iree/compiler/torch-mlir-import-onnx/OnnxImporter.cpp
Outdated
Show resolved
Hide resolved
vinayakdsci
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, many models would get an error from MLIR (ElementsAttr does not provide iteration facilities for type ).
This patch now enables importing initializers on demand, and disables serializing them in GraphProto obtained from onnxruntime::GraphView. The importer now generates correct IR for ONNX models, with correct number of inputs/outputs.