Skip to content

Commit

Permalink
Remove dep on shortfin benchmark in sgl benchmark,
Browse files Browse the repository at this point in the history
Make `merge_and_upload_reports` run conditionally on either succeeding
  • Loading branch information
stbaione committed Dec 3, 2024
1 parent 305c4b0 commit d78ab73
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/ci-sglang-benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,6 @@ jobs:

benchmark_sglang:
name: "SGLang Serving Benchmark With SGLang"
needs: benchmark_shortfin
if: always()
strategy:
matrix:
version: [3.11]
Expand Down Expand Up @@ -190,7 +188,7 @@ jobs:

merge_and_upload_reports:
name: "Merge and upload benchmark reports"
needs: [benchmark_shortfin, benchmark_sglang]
if: success() || needs.benchmark_shortfin.result == 'success' || needs.benchmark_sglang.result == 'success'
runs-on: ubuntu-24.04
defaults:
run:
Expand Down

0 comments on commit d78ab73

Please sign in to comment.