-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable SHORTFIN_ENABLE_TOKENIZERS
in Linux package builds
#679
Comments
We also can't use a github action to set up rust on the host machine like the shortfin CI workflow: shark-ai/.github/workflows/ci-libshortfin.yml Lines 91 to 97 in 7e62c25
since the Linux package builds are run in a manylinux docker container: shark-ai/shortfin/build_tools/build_linux_package.sh Lines 175 to 180 in 7e62c25
|
ScottTodd
added a commit
to nod-ai/base-docker-images
that referenced
this issue
Dec 12, 2024
Progress on nod-ai/shark-ai#679 Tested: ```bash cd base-docker-images sudo docker buildx build --file dockerfiles/manylinux_x86_64.Dockerfile . --tag manylinux:latest cd ../shark-ai CACHE_DIR=~/.shark-ai-cache \ OUTPUT_DIR=/tmp/wheelhouse \ MANYLINUX_DOCKER_IMAGE=manylinux:latest \ sudo -E ./shortfin/build_tools/build_linux_package.sh # ******************** BUILD COMPLETE ******************** # + echo 'Generated binaries:' # Generated binaries: # + ls -l /tmp/wheelhouse # total 40084 # -rw-r--r-- 1 root root 13691622 Dec 11 15:48 shortfin-3.0.0rc20241118-cp311-cp311-manylinux_2_28_x86_64.whl # -rw-r--r-- 1 root root 13682296 Dec 11 15:50 shortfin-3.0.0rc20241118-cp312-cp312-manylinux_2_28_x86_64.whl # -rw-r--r-- 1 root root 13666409 Dec 11 15:52 shortfin-3.0.0rc20241118-cp313-cp313-manylinux_2_28_x86_64.whl ``` Note that this image is in use without pinning in some repositories, but from what I can tell, all affected workflows are already failing and the code is unmaintained. For example: https://github.com/nod-ai/SRT/blob/373685f1cfff5dd6d934bf5858b6d58fc7a5bcdf/build_tools/pkgci/build_linux_packages.sh#L67.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This will allow us to replace the current loosely coupled tokenizers Python package (https://pypi.org/project/tokenizers/) with a source dependency on https://github.com/mlc-ai/tokenizers-cpp that provides bindings to the underlying rust library from https://github.com/huggingface/tokenizers and C++ library from https://github.com/google/sentencepiece.
See also:
Main tasks for this issue:
shark-ai/shortfin/build_tools/build_linux_package.sh
Lines 40 to 41 in 1e26b20
SHORTFIN_ENABLE_TOKENIZERS
in that scriptThe text was updated successfully, but these errors were encountered: