[types][shortfin_apps.sd] narrow InferenceExecRequest to SDXLInferenceExecRequest
#1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjacobgordon
force-pushed
the
types-shortfin_apps-sd-narrow-InferenceExecRequest-to-SDXLInferenceExecRequest
branch
from
a92e1c2 to
9c58464
Compare
|
Not code owner so not going to give explicit approval but: Having separate names for similar classes that do different things across apps would make my life easier when i do fuzzy finds |
bjacobgordon
force-pushed
the
types-shortfin_apps-sd-narrow-InferenceExecRequest-to-SDXLInferenceExecRequest
branch
from
9c58464 to
78d1d81
Compare
IanNod
approved these changes
Mar 10, 2025
…enceExecRequest`
bjacobgordon
force-pushed
the
types-shortfin_apps-sd-narrow-InferenceExecRequest-to-SDXLInferenceExecRequest
branch
from
78d1d81 to
493d9dd
Compare
bjacobgordon
deleted the
types-shortfin_apps-sd-narrow-InferenceExecRequest-to-SDXLInferenceExecRequest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.