-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shortfin] Add extras_require for optional deps. #240
Conversation
I don't have strong feelings as well and I am not sure about what names we really want to have. But I agree that 5 seems like a lot, especially as
We actually don't want to pull in some of the deps if installing 3.13t at all. Within my early experiments ONNX failed to install which is why I added
There might be even more options if we think about moving modernizing the project (https://packaging.python.org/en/latest/guides/modernize-setup-py-project/) and moving dependencies to our Side note: For nighties (as long as we don't publish via PyPI) we could add direct URL dependencies (see https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#direct-url-dependencies). However, as such packages cannot be published on PyPI this is nothing we want for releases. |
@stellaraccident we discussed this a bit today. Seems like we'll want a meta-package instead of putting more deps in shortfin itself? I was referencing this from #130 when I put together this draft PR:
|
Um: https://pypi.org/project/transformers/
Well there's an upper limit to keep in mind :P |
Here's what a meta package could look like instead of (or in addition to) these extras for |
Closing this in favor of a meta-package approach. |
Progress on #130
These optional dependencies can be installed with e.g.
pip install {INDEX URL HERE} shortfin[server]
.We can share these requirements with
requirements-*.txt
files using this technique, if we want: https://github.com/nod-ai/SHARK-Platform/blob/72665fc0e3e8d1ed3b4e7eacdfa9c493e2ba0852/sharktank/setup.py#L46-L57 https://github.com/nod-ai/SHARK-Platform/blob/72665fc0e3e8d1ed3b4e7eacdfa9c493e2ba0852/sharktank/setup.py#L100-L105Docs: https://setuptools.pypa.io/en/latest/userguide/dependency_management.html