Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shortfin] Fix mobilenet_server example by filling mapped storage. #241

Merged
merged 3 commits into from
Oct 3, 2024
Merged

[shortfin] Fix mobilenet_server example by filling mapped storage. #241

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6d60e0
[shortfin] Fix mobilenet_server example by writing bytes directly.
ScottTodd Oct 1, 2024
1e80528
Use fill instead of indexing byte by byte.
ScottTodd Oct 3, 2024
a3c96fe
Merge branch 'main' into shortfin-example-io
ScottTodd Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion shortfin/examples/python/mobilenet_server/inference_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ async def run(self):
# just writing to the backing storage is the best we have API
# support for. Generally, APIs on storage should be mirrored onto
# the array.
self.host_staging.storage.data = request.raw_image_data
# TODO: Easier to use API for writing into the storage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grrg. Yeah, these low level transfer methods need an upgrade. Up until the most recent commit, I didn't have the device level metadata I needed to determine the right way to load data on to the device (i.e. map, transfer, chunk, etc). Now that I have that, need to design a more ergonomic API.

With that said, I believe that mapping.fill(buffer) will do what you want if the buffer is the size of the target (i.e. it will copy x1 vs tile). There are some tests that exercise that.

So I think you can say:

with self.host_staging.storage.map(write=True, discard=True) as m:
  m.fill(request.raw_image_data)

(assuming sizes line up)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, fill works. I saw that API and thought it would only work for a pattern of bytes, based on my read the docs: https://shortfin.readthedocs.io/en/latest/reference.html#shortfin_default.lib.array.storage.fill (also seems like docs are missing for the result of map()... should make sure we have cross reference links between all the types).

with self.host_staging.storage.map(write=True, discard=True) as m:
m.fill(request.raw_image_data)
print("host_staging =", self.host_staging)
self.device_input.copy_from(self.host_staging)

Expand Down
Loading