Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shortfin] Upgrade package build dockerfile to manylinux_2_28. #627

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

ScottTodd
Copy link
Member

Progress on #130.

The manylinux2014 image includes gcc 10.2.1 by default while manylinux_2_28 includes gcc 12.2.1. At one point we had warnings/errors building on the newer gcc version, but that is no longer the case.

With the new Rust dependency coming from #610, we will likely want to revive https://github.com/nod-ai/base-docker-images/blob/main/dockerfiles/manylinux_x86_64.Dockerfile, add more dependencies there, then switch from the upstream quay.io/... image to that ghcr.io/nod-ai/... image.

Tested locally with OUTPUT_DIR="/tmp/wheelhouse" sudo -E ./build_tools/build_linux_package.sh. If the nightly package build fails for some reason we can easily revert this.

@ScottTodd
Copy link
Member Author

With the new Rust dependency coming from #610, we will likely want to revive https://github.com/nod-ai/base-docker-images/blob/main/dockerfiles/manylinux_x86_64.Dockerfile, add more dependencies there, then switch from the upstream quay.io/... image to that ghcr.io/nod-ai/... image.

As expected, flipping SHORTFIN_ENABLE_TOKENIZERS=ON using the stock manylinux image results in:

  CMake Error at CMakeLists.txt:261 (message):
    Building with -DSHORTFIN_ENABLE_TOKENIZERS=ON requires cargo (Rust's build
    tool).  Please follow Rust documentation to install.  On Ubuntu, this can
    typically be accomplished with:

      sudo apt install rustup && rustup default stable

    See https://www.rust-lang.org/tools/install
  Call Stack (most recent call first):
    CMakeLists.txt:290 (shortfin_check_tokenizers)

@ScottTodd ScottTodd merged commit 4666afe into nod-ai:main Dec 2, 2024
16 of 19 checks passed
@ScottTodd ScottTodd deleted the shortfin-manylinux-2-28 branch December 2, 2024 18:26
monorimet pushed a commit that referenced this pull request Dec 13, 2024
Progress on #130.

The manylinux2014 image includes gcc 10.2.1 by default while
manylinux_2_28 includes gcc 12.2.1. At one point we had warnings/errors
building on the newer gcc version, but that is no longer the case.

With the new Rust dependency coming from
#610, we will likely want to
revive
https://github.com/nod-ai/base-docker-images/blob/main/dockerfiles/manylinux_x86_64.Dockerfile,
add more dependencies there, then switch from the upstream `quay.io/...`
image to that `ghcr.io/nod-ai/...` image.

Tested locally with `OUTPUT_DIR="/tmp/wheelhouse" sudo -E
./build_tools/build_linux_package.sh`. If the nightly package build
fails for some reason we can easily revert this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants