Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump IREE to latest commit on main. #722

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
+9 −6
Draft

Bump IREE to latest commit on main. #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bd5b79a
Bump IREE to iree-3.1.0rc20241217
eagarvey-amd Dec 18, 2024
8d1181c
Bump IREE version in libshortfin workflows.
eagarvey-amd Dec 18, 2024
0c29122
Merge branch 'main' into ean-bump-iree-shortfin
monorimet Dec 18, 2024
5816eac
Bump again from 17 to 20.
ScottTodd Dec 20, 2024
b6c547c
Format files.
ScottTodd Dec 20, 2024
60ff8ba
Merge remote-tracking branch 'upstream/main' into bump-iree-3.1.0rc20…
ScottTodd Dec 20, 2024
b713b35
Pin to latest commit on main to test the latest changes.
ScottTodd Dec 20, 2024
75b7227
Adapt to `iree_io_parse_file_index` API change.
ScottTodd Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-libshortfin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
repository: iree-org/iree
path: ${{ env.IREE_REPO_DIR }}
submodules: false
ref: iree-3.1.0rc20241204
ref: 0a0483e997bea993cdf26e62ef5c68a043011e1b

- name: Initalize IREE submodules
working-directory: ${{ env.IREE_REPO_DIR }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_linux_x64_asan-libshortfin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
repository: iree-org/iree
path: ${{ env.IREE_SOURCE_DIR }}
submodules: false
ref: iree-3.1.0rc20241204
ref: 0a0483e997bea993cdf26e62ef5c68a043011e1b

- name: Initalize IREE submodules
working-directory: ${{ env.IREE_SOURCE_DIR }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_linux_x64_nogil-libshortfin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
repository: iree-org/iree
path: ${{ env.IREE_REPO_DIR }}
submodules: false
ref: iree-3.1.0rc20241204
ref: 0a0483e997bea993cdf26e62ef5c68a043011e1b

- name: Initalize IREE submodules
working-directory: ${{ env.IREE_REPO_DIR }}
Expand Down
3 changes: 2 additions & 1 deletion shortfin/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ add_compile_options("$<$<C_COMPILER_ID:MSVC>:/utf-8>")
add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/utf-8>")

# Pins
set(SHORTFIN_IREE_GIT_TAG "iree-3.1.0rc20241204")
# TODO: switch back to a tag like `iree-3.1.0rc20241220` after the next nightly release.
set(SHORTFIN_IREE_GIT_TAG "0a0483e997bea993cdf26e62ef5c68a043011e1b")

# build options
option(SHORTFIN_BUILD_PYTHON_BINDINGS "Builds Python Bindings" OFF)
Expand Down
3 changes: 2 additions & 1 deletion shortfin/src/shortfin/array/storage.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ storage storage::subspan(iree_device_size_t byte_offset,
iree_device_size_t byte_length) {
storage new_storage(device_, {}, timeline_resource_);
SHORTFIN_THROW_IF_ERROR(iree_hal_buffer_subspan(
buffer_, byte_offset, byte_length, new_storage.buffer_.for_output()));
buffer_, byte_offset, byte_length, host_allocator(),
new_storage.buffer_.for_output()));
return new_storage;
}

Expand Down
3 changes: 2 additions & 1 deletion shortfin/src/shortfin/local/program.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,8 @@ void StaticProgramParameters::Load(std::filesystem::path file_path,

// Parse.
SHORTFIN_THROW_IF_ERROR(iree_io_parse_file_index(
to_iree_string_view(options.format), file_handle.get(), index_.get()));
to_iree_string_view(options.format), file_handle.get(), index_.get(),
host_allocator_));
}

// -------------------------------------------------------------------------- //
Expand Down
Loading