Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed setSignal and added catch all exception implementation #10

Merged
merged 7 commits into from
May 30, 2024
Merged

fixed setSignal and added catch all exception implementation #10

merged 7 commits into from
May 30, 2024

Conversation

epessoa-i
Copy link
Contributor

This patch:

  • fixes setSignal (the boolean parameter is not correctly taken)
  • adds TypeScript definition to the missing exports
  • fixes the includePath in cpp vscode configuration
  • adds the ability to capture all exceptions

@raub
Copy link
Member

raub commented May 30, 2024

Nice work! Thank you

@raub raub merged commit 7c94598 into node-3d:master May 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epessoa-i @raub