Skip to content

Conditional loading #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 15, 2021
Merged

Conditional loading #104

merged 8 commits into from
Jul 15, 2021

Conversation

jimmywarting
Copy link
Contributor

best way to conditionally load libraries without the use of top level await (that requires node 14) was to use cjs

still works to import it totally fine in deno and browser without bundling

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #104 (b111425) into master (701103f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #104   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         4    +1     
  Lines          397       401    +4     
  Branches        58        59    +1     
=========================================
+ Hits           397       401    +4     
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)
streams.cjs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 701103f...b111425. Read the comment docs.

@jimmywarting jimmywarting merged commit 52f296c into master Jul 15, 2021
@jimmywarting jimmywarting deleted the conditional-loading branch July 15, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant