-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prefix stream/web import with node:
#122
Conversation
b187f8f
to
07227e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat 👍
Codecov Report
@@ Coverage Diff @@
## main #122 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 4
Lines ? 425
Branches ? 69
========================================
Hits ? 425
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
a better detection (on your end) would be to discard everything after a |
per the issue description, |
touché |
Thanks! Any chance we can get a new release with this included? |
it didn't bring much new to the table that it was so much worth making a release out of. but i guess we could make a new patch release i have found out that NodeJS now have added a Readable.toWeb and a |
A new patch release would be great. No project that's using |
okey |
great, thanks! Netlify has merged the fix on their end (netlify/zip-it-and-ship-it#773), so all we need is a release here and then folks should be able to use this library on Netlify again |
it's on my agenda, i where just thinking if maybe i could get #125 merged first. I would like for someone to cast just an eye on it first. After that i will make a new release |
The purpose of this PR is:
Making it more obvious that
stream/web
is a Node built-in. Since we upgraded tonode-fetch
3.0 final our deploys are failing on Netlify (netlify/zip-it-and-ship-it#743). I'm hoping this would be part of a solutionThis is what had to change:
Add
node:
prefixThis is what like reviewers to know:
This is a supported syntax for importing core modules. I believe the
node:
prefix is only available on Node 16. However, sincestream/web
is only available on Node 16 as well, I don't think that should be an issue. It does skip the require cache, which might cause some small performance loss - if the user's application is importingstream/web
elsewhere I believe this will cause a new instance to be importedI might wait to merge this until seeing what the reviewers of the detection package think about the idea as well (dependents/node-precinct#88). However, I thought I'd at least raise it here to see whether you'd be amenable to the idea.
docs:
,fix(area):
,feat(area):
orbreaking(area):