to solve EISDIR error #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to solve EISDIR error when trying to submit a form with no file selected.
Member
|
Please remove needless added |
remove needless .idea things and change the condition to !part.filename
remove needless .idea
Contributor
Author
|
@tunnckoCore I have removed .idea things and changed the condition to !part.filename |
Member
|
Thanks! Use the master for install, because it's not sure when new release will come. |
Closed
kornelski
added a commit
that referenced
this pull request
Sep 26, 2017
This reverts commit 05e4743.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to solve EISDIR error when trying to submit a form with no file selected.
When we tried to submit a form with no file selected, then part.filename is '' but not undefined. And I think fomidable should handle this situation.
We can also modify like below:
IncomingForm.prototype.onPart = function(part) {
// this method can be overwritten by the user
if (part.filename !== '') {
this.handlePart(part);
}
};
If we don't do this, then the code will go to "file.open()" (lib/incoming_form.js:215) and then it will throw EISDIR error and then our process will stop.