Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: IncomingForm end event emitted twice #852

Merged
merged 3 commits into from
Apr 26, 2022
Merged

fix: IncomingForm end event emitted twice #852

merged 3 commits into from
Apr 26, 2022

Conversation

jimmyolo
Copy link
Collaborator

closes to #810

@GrosSacASac GrosSacASac merged commit 92df3c8 into node-formidable:master Apr 26, 2022
@GrosSacASac
Copy link
Contributor

Thanks

@gaganjot99
Copy link

Issue still persisting for me.
I just reinstalled formidable, end event again is being emitted twice
I have files input, For some reason it only happens when I include only one file but for two or more files it works perfectly.

@tunnckoCore
Copy link
Member

use npm install node-formidable/formidable (the master branch), it's not yet in NPM i think.

@gaganjot99

@gaganjot99
Copy link

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrosSacASac GrosSacASac GrosSacASac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimmyolo @GrosSacASac @gaganjot99 @tunnckoCore