fix: Use fileBegin hook to properly fail when maxFiles is exceeded #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, using the
"file"(file completion) hook to check the maxFiles restriction allows an extra file to be uploaded.This is because if
_erroris called after the last file is uploaded,this.endedis already set to true and the error is ignored.By using the
"fileBegin"hook instead, the error is triggered before the file has finished uploading.This also allows the server to fail immediately upon the file upload, which means it doesn't have to wait for the extra upload that will be discarded anyways.