Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query for phrases and add --best and --bestof options #9

Merged
merged 3 commits into from
May 16, 2015
Merged

Fix query for phrases and add --best and --bestof options #9

merged 3 commits into from
May 16, 2015

Commits on Nov 29, 2014

  1. Use encodeURIComponent to search terms 

      * Allow more accurate queries like `gh gif 3 -R "jim carrey dancing"`
    @felquis
    felquis committed Nov 29, 2014
    Configuration menu
    Copy the full SHA
    3fa5cb2 View commit details
    Browse the repository at this point in the history

  2. Add --best options 

    When --best is defined, we use the best search result.
    @felquis
    felquis committed Nov 29, 2014
    Configuration menu
    Copy the full SHA
    77c63b6 View commit details
    Browse the repository at this point in the history

  3. Add --bestof option 

    Can be used any number, the random will be based in this number. For
example, "--bestof 4" we get the first four items of the search result,
then use a random item of these four items.

This is good for a more accurate search, for example `gh gif 3 -R
"batman dancing" -B 3` I already know that only the first 3 items are
cool, but I don't like the others.
    @felquis
    felquis committed Nov 29, 2014
    Configuration menu
    Copy the full SHA
    2bdc76e View commit details
    Browse the repository at this point in the history