Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Mac M1 support #214

Open
deepy opened this issue Feb 10, 2022 · 3 comments
Open

Improve Mac M1 support #214

deepy opened this issue Feb 10, 2022 · 3 comments

Comments

@deepy
Copy link
Member

deepy commented Feb 10, 2022

Extracting #204

But instead of using uname on M1 macs we should be using sysctl sysctl.proc_translated
deepy added a commit that referenced this issue Feb 10, 2022
@deepy
If uname returns x86_64 on Mac, use x64 binary #214
ac3f280 
Even if we were launched by aarch64 Java, see #204 for discussion.
@Vampire
Copy link

Vampire commented Apr 14, 2022

Should this be closed? The changelog claims this is fixed for 3.2.1

@deepy
Copy link
Member Author

deepy commented Apr 14, 2022

The current solution in 3.2.1 is using uname which as far as I can tell should always be correct (but according to testimonies in #204 that's not true)

My new work laptop is a M1 mac and as soon as I get that I'll switch to sysctl sysctl.proc_translated

@deepy
Copy link
Member Author

deepy commented Oct 22, 2022

After fixing #234 an option could be added to automatically run older node versions through Rosetta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Vampire @deepy