Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit and verify inputs/outputs #34

Closed
4 tasks done
deepy opened this issue Sep 16, 2019 · 0 comments
Closed
4 tasks done

Revisit and verify inputs/outputs #34

deepy opened this issue Sep 16, 2019 · 0 comments
Milestone
3.0

Comments

@deepy
Copy link
Member

deepy commented Sep 16, 2019 •
edited by bsautel
Loading

extracted from #32
Definitely needs to be checked:

  • NpmSetupTask
    • @input getInput() has a File in it's list.
  • YarnTask
  • ExecRunner
    • @input on Optional getWorkingDir()
    • especially execOverrides, there's an old PR at srs which might solve this.

Needs tests to prove it works:

  • YarnTask
@deepy deepy mentioned this issue Sep 18, 2019
Merged
@bsautel bsautel added this to the 3.0 milestone Apr 7, 2020
bsautel added a commit that referenced this issue Apr 19, 2020
@bsautel
Fix issue #34. Improve inputs definition for the npmSetup and yarnSet…
ed93ef3 
…up tasks.
@bsautel bsautel closed this as completed Apr 19, 2020
bsautel added a commit that referenced this issue Apr 27, 2020
@bsautel
Fix issue #34. Improve inputs definition for the npmSetup and yarnSet…
f94a4ef 
…up tasks.
stuartraetaylor added a commit to stuartraetaylor/gradle-node-plugin that referenced this issue Nov 24, 2020
@stuartraetaylor
Merge tag '3.0.0-rc4' into multifix
75f8efb 
3.0.0-rc4 - kotlin rewrite, lazy configuration, api changes, proxy fixes.
* Plugin rewritten in Kotlin (issue node-gradle#17) (thanks mikejhill for the pull request)
* Improved Kotlin DSL support
* Upgraded default Node.js version to 12.18.1 (bundled with npm 6.14.5), the latest LTS version
* Lazy configuration support
* Fix some remaining input/output declaration issues (issue node-gradle#34)
* Gradle 5.6.4+ support (instead of Gradle 5.0.0+ before)
* Node.js 10+ support (issue node-gradle#100)
* Use http:// for both HTTP and HTTPS_PROXY
* No longer configures proxy if there's already proxy settings present
* Support for npm 7+ node-gradle#123

See CHANGELOG for full details and upgrade instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@deepy @bsautel