Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow insecure protocol #164

Merged
merged 10 commits into from
Dec 13, 2021
Merged

Conversation

markslater
Copy link
Contributor

Implements #163 to allow Gradle 7.0+ to download Node over HTTP: Adds allowInsecureProtocol flag to NodeExtension taking three possible values:

  1. true: Allow download over HTTP
  2. false: Require download over HTTPS
  3. null: Use Gradle default behaviour for permitting/denying HTTP downloads (permit prior to Gradle 7.0, deny from Gradle 7.0 on)

@markslater
Copy link
Contributor Author

Let me know if this needs further changes, or if I've got the wrong end of the stick with any of the review comments.

@ajzawawi
Copy link

ajzawawi commented Jun 1, 2021

@bsautel Would greatly appreciate it if we can get this merged. We have the same issue where we're behind a corporate proxy and need this option to resolve our node dependency.

@deepy deepy self-assigned this Jun 7, 2021
@deepy deepy added this to the 3.2 milestone Oct 21, 2021
@blling
Copy link

blling commented Dec 10, 2021

When to release? :-)

@deepy
Copy link
Member

deepy commented Dec 10, 2021

It's coming in the next version, but there were test failures when I ran the tests locally so I need to look into if it was the tests or the merge broke

@deepy deepy merged commit bd6884a into node-gradle:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants