Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump v8-debug to 0.4.2 and v8-profiler to 5.2.4 for iojs support #563

Closed
wants to merge 1 commit into from

Conversation

jimthedev
Copy link
Contributor

Fixes #523.

@bajtos
Copy link
Member

bajtos commented Feb 19, 2015

@3y3 PTAL

@jimthedev
Copy link
Contributor Author

As I noted here: node-inspector/v8-debug#12 (comment)

I need to update this PR once both my debug and profiler prs are merged to see if tests finish in CI. They do finish locally when both v8 deps use at least node-pre-gyp 0.6.4

@3y3
Copy link
Member

3y3 commented Feb 19, 2015

v8-debug 0.4.1 and v8-profiler 5.2.4 released.
I'll ready to merge this pr, after updating it.

@jimthedev jimthedev changed the title Bump v8-debug dependency to 0.0.4 for iojs support Bump v8-debug to 0.4.1 and v8-profiler to 5.2.4 for iojs support Feb 20, 2015
@jimthedev
Copy link
Contributor Author

I'm having trouble figuring out why the startProfiler test is failing. Is seems like everything is properly set up. Can anyone else have a look?

@3y3
Copy link
Member

3y3 commented Feb 22, 2015

I'm having trouble figuring out why the startProfiler test is failing. Is seems like everything is properly set up. Can anyone else have a look?

This is out of scope of this commit. I work on this issue in current time. In v8-debug 0.4.2 I fixed completely main blocking issue for Node Inspector's new features (nodejs/node-v0.x-archive#9156).

I don't understand why tests doesn't pass for Profiler and HeapProfiler API after v8-debug 0.4.2, but it's not so important now.

Please update v8-debug to 0.4.2 in commit.
Also we don't use dirty merging in node-inspector - please use rebase for clean commit history.

@jimthedev jimthedev changed the title Bump v8-debug to 0.4.1 and v8-profiler to 5.2.4 for iojs support Bump v8-debug to 0.4.2 and v8-profiler to 5.2.4 for iojs support Feb 23, 2015
@jimthedev
Copy link
Contributor Author

Ok @3y3 cleaned up my history and changed the version to 0.4.2. Will wait for you on the profiler test failures.

@3y3
Copy link
Member

3y3 commented Feb 23, 2015

Landed as 08001e1
Thank you!

@3y3 3y3 closed this Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with io.js
3 participants