Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An export assignment cannot be used in a module with other exported elements. #73

Closed
AndrewLeedham opened this issue Feb 19, 2019 · 3 comments · Fixed by #74
Closed

An export assignment cannot be used in a module with other exported elements. #73

AndrewLeedham opened this issue Feb 19, 2019 · 3 comments · Fixed by #74

Comments

@AndrewLeedham
Copy link
Contributor

image

index.d.ts uses export = internal, as well as conventional exports, TS doesn't seem to be happy with this. Perhaps exporting HttpAgent as default would be more appropriate?
AndrewLeedham added a commit to AndrewLeedham/agentkeepalive that referenced this issue Feb 19, 2019
@AndrewLeedham
fix: HttpAgent export = internal
5246af9 
fixes: node-modules#73
This was referenced Feb 19, 2019
Merged
Merged
@AndrewLeedham
Copy link
Contributor Author

Seems like this was caused when #70 was merged.

fengmk2 pushed a commit that referenced this issue Feb 19, 2019
@AndrewLeedham @fengmk2
fix: HttpAgent export = internal (#74)
56d4a9b 
closes #73
@fengmk2
Copy link
Member

fengmk2 commented Feb 19, 2019

Please test on 4.0.2

@AndrewLeedham
Copy link
Contributor Author

Please test on 4.0.2

All working, no TS errors 👍 thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: HttpAgent export = internal AndrewLeedham/agentkeepalive
2 participants
@fengmk2 @AndrewLeedham