feat: support revert array in vm

node-modules · Jul 10, 2023 · 69ae281 · 69ae281
1 parent 662ea81
commit 69ae281
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/revert.js b/lib/revert.js
@@ -48,7 +48,7 @@ function derecycle(java, refs, path) {
       result[k] = derecycle(v, refs, path ? path + DELIMITER + k : k);
     });
   */
-  } else if (java instanceof Array) {
+  } else if (Array.isArray(java)) {
     result = [];
     java.forEach(function(v, i) {
       result[i] = derecycle(v, refs, path ? path + DELIMITER + i : i + '');

diff --git a/test/revert.test.js b/test/revert.test.js
@@ -1,5 +1,6 @@
 'use strict';
 
+var vm = require('vm');
 require('should');
 var revert = require('../index').revert;
 
@@ -85,6 +86,18 @@ describe('revert: java to js', function() {
     revert(java).should.eql(['foo', 'bar', 'zoo']);
   });
 
+  it('should work with list in vm', function() {
+    var java = [2, 3, 5];
+    revert(java).should.eql(java);
+
+    java = new vm.Script(`[
+      {$class: 'string', $: 'foo'},
+      {$class: 'string', $: 'bar'},
+      {$class: 'string', $: 'zoo'},
+    ]`).runInNewContext({});
+    revert(java).should.eql(['foo', 'bar', 'zoo']);
+  });
+
 
   it('should work when used with cycular reference', function() {
     var java, result;