Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set error file path into error message #25

Merged
merged 4 commits into from
Jul 18, 2016
Merged

feat: set error file path into error message #25

merged 4 commits into from
Jul 18, 2016

Conversation

dead-horse
Copy link
Member

No description provided.

@popomore
Copy link
Member

popomore commented Jul 7, 2016

+1

@popomore
Copy link
Member

popomore commented Jul 7, 2016

用例挂了

@dead-horse
Copy link
Member Author

这个错误信息里没有报错位置的问题只有在 node@4 和 node@5 下有，在 node@0.12 和 node@6 里面都已经修复了

@dead-horse
Copy link
Member Author

提个 issue 看看有没有人反馈，这个先不着急合 nodejs/node#7578

@dead-horse
Copy link
Member Author

看来有希望直接在 node@4 上 fix 这个问题

@dead-horse
Copy link
Member Author

node@4 也没法修，那我修一下 CI 吧�

@dead-horse
Copy link
Member Author

用例修复了

@fengmk2
Copy link
Member

fengmk2 commented Jul 18, 2016

+1

@fengmk2
Copy link
Member

fengmk2 commented Jul 18, 2016

我先修 debug，然后再合并。

@fengmk2 fengmk2 merged commit 0d6ddd3 into master Jul 18, 2016
@fengmk2 fengmk2 deleted the syntax-error branch July 18, 2016 10:10
@fengmk2
Copy link
Member

fengmk2 commented Jul 18, 2016

1.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fengmk2 fengmk2

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dead-horse @popomore @fengmk2